Browse Source

Fixes #908: narrow inVerse login form when `allow_registration` is `false`.

JC Brand 7 years ago
parent
commit
4da4131003
2 changed files with 7 additions and 6 deletions
  1. 3 2
      CHANGES.md
  2. 4 4
      src/converse-inverse.js

+ 3 - 2
CHANGES.md

@@ -4,8 +4,9 @@
 
 ### Bugfixes
 - Various IE11 fixes.
-- Translations written as template literals [aren't parsed properly by xgettext](https://savannah.gnu.org/bugs/?50920).
-- Fix regarding ChatRoomView.getDefaultNickName() and muc_nickname_from_jid
+- #908 Login form for inVerse is only 200px when `allow_registration` is set to `false`.
+- #909 Translations written as template literals [aren't parsed properly by xgettext](https://savannah.gnu.org/bugs/?50920).
+- #911 Use `getDefaultNickName` consistently to allow better overrides via plugins.
 
 ## 3.2.0 (2017-08-09)
 

+ 4 - 4
src/converse-inverse.js

@@ -65,16 +65,16 @@
 
                 renderRegistrationPanel () {
                     this.__super__.renderRegistrationPanel.apply(this, arguments);
-
-                    const el = document.getElementById('converse-register');
-                    el.parentNode.insertBefore(createBrandHeadingElement(), el);
+                    if (this.__super__._converse.allow_registration) {
+                        const el = document.getElementById('converse-register');
+                        el.parentNode.insertBefore(createBrandHeadingElement(), el);
+                    }
                     return this;
                 },
 
                 renderLoginPanel () {
                     this.__super__.renderLoginPanel.apply(this, arguments);
                     this.el.classList.add("fullscreen");
-
                     const el = document.getElementById('converse-login');
                     el.parentNode.insertBefore(createBrandHeadingElement(), el);
                     return this;