ソースを参照

Some usability fixes around the toolbar and emojis

JC Brand 8 年 前
コミット
4e467044d3
2 ファイル変更7 行追加5 行削除
  1. 6 4
      src/converse-chatview.js
  2. 1 1
      src/converse-muc.js

+ 6 - 4
src/converse-chatview.js

@@ -703,15 +703,17 @@
                     } else {
                     } else {
                         target = ev.target;
                         target = ev.target;
                     }
                     }
-                    this.insertIntoTextArea(
-                        emojione.shortnameToUnicode(
-                            target.getAttribute('data-emoticon')
-                        ));
+                    var shortname = target.getAttribute('data-emoticon');
+                    this.insertIntoTextArea( emojione.shortnameToUnicode(shortname));
                 },
                 },
 
 
                 toggleEmoticonMenu: function (ev) {
                 toggleEmoticonMenu: function (ev) {
                     if (!_.isUndefined(ev)) {
                     if (!_.isUndefined(ev)) {
                         ev.stopPropagation();
                         ev.stopPropagation();
+                        if (ev.target.classList.contains('emoji-category-picker') ||
+                                ev.target.classList.contains('emoji-category')) {
+                            return;
+                        }
                     }
                     }
                     utils.toggleElement(this.emoji_picker_view.el);
                     utils.toggleElement(this.emoji_picker_view.el);
                 },
                 },

+ 1 - 1
src/converse-muc.js

@@ -438,7 +438,7 @@
                     'click .close-chatbox-button': 'close',
                     'click .close-chatbox-button': 'close',
                     'click .configure-chatroom-button': 'getAndRenderConfigurationForm',
                     'click .configure-chatroom-button': 'getAndRenderConfigurationForm',
                     'click .toggle-smiley': 'toggleEmoticonMenu',
                     'click .toggle-smiley': 'toggleEmoticonMenu',
-                    'click .toggle-smiley ul li': 'insertEmoticon',
+                    'click .toggle-smiley ul.emoji-picker li': 'insertEmoticon',
                     'click .toggle-clear': 'clearChatRoomMessages',
                     'click .toggle-clear': 'clearChatRoomMessages',
                     'click .toggle-call': 'toggleCall',
                     'click .toggle-call': 'toggleCall',
                     'click .toggle-occupants a': 'toggleOccupants',
                     'click .toggle-occupants a': 'toggleOccupants',