Explorar o código

Bail when in a callback for a hanging chatroom

JC Brand %!s(int64=7) %!d(string=hai) anos
pai
achega
4f7c08b1da
Modificáronse 1 ficheiros con 6 adicións e 0 borrados
  1. 6 0
      src/converse-muc-views.js

+ 6 - 0
src/converse-muc-views.js

@@ -531,6 +531,12 @@
 
                     if (this.model.get('connection_status') !==  converse.ROOMSTATUS.ENTERED) {
                         const handler = () => {
+                            if (!u.isPersistableModel(this.model)) {
+                                // Happens during tests, nothing to do if this
+                                // is a hanging chatbox (i.e. not in the
+                                // collection anymore).
+                                return;
+                            }
                             this.join();
                             this.fetchMessages();
                             _converse.emit('chatRoomOpened', this);