Explorar o código

Bugfix. First configure `browserStorage` for ChatBoxes

before populating the roster.
JC Brand %!s(int64=8) %!d(string=hai) anos
pai
achega
586bbd0e4d
Modificáronse 2 ficheiros con 5 adicións e 2 borrados
  1. 3 0
      docs/CHANGES.md
  2. 2 2
      src/converse-core.js

+ 3 - 0
docs/CHANGES.md

@@ -6,6 +6,9 @@
   For details, refer to the [relevant documentation](https://conversejs.org/docs/html/developer_api.html#the-rooms-grouping) [jcbrand]
 - Bugfix: Arrays in configuration settings were ignored. [jcbrand]
 - Bugfix: Chatboxes aren't closed when logging out. [jcbrand]
+- Bugfix: Trying to save data on the `ControlBox` model before `ChatBoxes`
+  collection has its `browserStorage` configured.
+  Causes `Error: A "url" property or function must be specified`. [jcbrand]
 
 ## 2.0.1 (2016-11-07)
 - #203 New configuration setting [muc_domain](https://conversejs.org/docs/html/configuration.html#muc_domain) [jcbrand]

+ 2 - 2
src/converse-core.js

@@ -673,8 +673,8 @@
         this.onStatusInitialized = function () {
             converse.registerIntervalHandler();
             converse.initRoster();
-            converse.populateRoster();
             converse.chatboxes.onConnected();
+            converse.populateRoster();
             converse.registerPresenceHandler();
             converse.giveFeedback(__('Contacts'));
             if (typeof converse.callback === 'function') {
@@ -729,8 +729,8 @@
             // Give event handlers a chance to register views for the roster
             // and its groups, before we start populating.
             converse.emit('rosterReadyAfterReconnection');
-            converse.populateRoster();
             converse.chatboxes.onConnected();
+            converse.populateRoster();
             converse.xmppstatus.sendPresence();
             converse.emit('reconnected');
             converse.giveFeedback(__('Contacts'));