Forráskód Böngészése

fixes #2396: @converse/headless wrongly depends on `CustomElement` from the view layer

JC Brand 4 éve
szülő
commit
5cab477bf4
3 módosított fájl, 5 hozzáadás és 3 törlés
  1. 1 0
      CHANGES.md
  2. 4 1
      src/converse.js
  3. 0 2
      src/headless/core.js

+ 1 - 0
CHANGES.md

@@ -4,6 +4,7 @@
 
 - #1083: Add support for XEP-0393 Message Styling
 - #2275: Allow punctuation to immediately precede a mention
+- #2396: @converse/headless wrongly depends on `CustomElement` from the view layer
 - #2400: Fixes infinite loop bug when appending .png to allowed image urls
 - #2409: Integrate App Badging API for unread messages
 - Add support for XEP-0437 Room Activity Indicators see [muc-subscribe-to-rai](https://conversejs.org/docs/html/configuration.html#muc-subscribe-to-rai)

+ 4 - 1
src/converse.js

@@ -35,7 +35,10 @@ import "./plugins/singleton.js";
 import "./components/converse.js";
 import "../sass/converse.scss";
 
-import { converse } from "@converse/headless/core";
+import { _converse, converse } from "@converse/headless/core";
+import { CustomElement } from 'components/element';
+
+_converse.CustomElement = CustomElement;
 
 const WHITELISTED_PLUGINS = [
     'converse-bookmark-views',

+ 0 - 2
src/headless/core.js

@@ -15,7 +15,6 @@ import sizzle from 'sizzle';
 import u from '@converse/headless/utils/core';
 import { Collection } from "@converse/skeletor/src/collection";
 import { Connection, MockConnection } from '@converse/headless/shared/connection.js';
-import { CustomElement } from '../components/element';
 import { Events } from '@converse/skeletor/src/events.js';
 import { Model } from '@converse/skeletor/src/model.js';
 import { Router } from '@converse/skeletor/src/router.js';
@@ -1650,7 +1649,6 @@ Object.assign(converse, {
         $pres,
         'utils': u,
         Collection,
-        CustomElement,
         Model,
         Promise,
         Strophe,