浏览代码

Fix race condition in test

JC Brand 4 年之前
父节点
当前提交
623deac3ec
共有 2 个文件被更改,包括 3 次插入2 次删除
  1. 1 1
      spec/emojis.js
  2. 2 1
      src/plugins/chatview/bottom-panel.js

+ 1 - 1
spec/emojis.js

@@ -50,7 +50,7 @@ describe("Emojis", function () {
             }
             const bottom_panel = view.querySelector('converse-muc-bottom-panel');
             bottom_panel.onKeyDown(tab_event);
-            await u.waitUntil(() => view.querySelector('converse-emoji-picker .emoji-search').value === ':gri');
+            await u.waitUntil(() => view.querySelector('converse-emoji-picker .emoji-search')?.value === ':gri');
             await u.waitUntil(() =>  sizzle('.emojis-lists__container--search .insert-emoji', view).length === 3, 1000);
             let visible_emojis = sizzle('.emojis-lists__container--search .insert-emoji', view);
             expect(visible_emojis[0].getAttribute('data-emoji')).toBe(':grimacing:');

+ 2 - 1
src/plugins/chatview/bottom-panel.js

@@ -253,7 +253,8 @@ export default class ChatBottomPanel extends ElementView {
         this.insertIntoTextArea('', true, false);
     }
 
-    autocompleteInPicker (input, value) {
+    async autocompleteInPicker (input, value) {
+        await api.emojis.initialize();
         const emoji_dropdown = this.querySelector('converse-emoji-dropdown');
         const emoji_picker = this.querySelector('converse-emoji-picker');
         if (emoji_picker && emoji_dropdown) {