Browse Source

Don't use id for controlbox panes

JC Brand 11 years ago
parent
commit
7f4bdb4098
3 changed files with 6 additions and 6 deletions
  1. 1 1
      converse.css
  2. 3 3
      converse.js
  3. 2 2
      spec/MainSpec.js

+ 1 - 1
converse.css

@@ -613,7 +613,7 @@
     background-color: #DCEAC5;
 }
 
-#chatpanel div#controlbox-panes {
+#chatpanel div.controlbox-panes {
     background: -moz-linear-gradient(top, rgba(255,255,255,1) 0%, rgba(240,240,240,1) 100%); /* FF3.6+ */
     background: -ms-linear-gradient(top, rgba(255,255,255,1) 0%,rgba(240,240,240,1) 100%); /* IE10+ */
     background: -o-linear-gradient(top, rgba(255,255,255,1) 0%,rgba(240,240,240,1) 100%); /* Opera 11.10+ */

+ 3 - 3
converse.js

@@ -1098,7 +1098,7 @@
                     '<ul id="controlbox-tabs"></ul>'+
                     '<a class="close-chatbox-button icon-close"></a>'+
                 '</div>'+
-                '<div id="controlbox-panes"></div>'
+                '<div class="controlbox-panes"></div>'
             ),
 
             switchTab: function (ev) {
@@ -1125,11 +1125,11 @@
                 if ((!converse.prebind) && (!converse.connection)) {
                     // Add login panel if the user still has to authenticate
                     this.$el.html(this.template(this.model.toJSON()));
-                    this.loginpanel = new converse.LoginPanel({'$parent': this.$el.find('#controlbox-panes'), 'model': this});
+                    this.loginpanel = new converse.LoginPanel({'$parent': this.$el.find('.controlbox-panes'), 'model': this});
                     this.loginpanel.render();
                 } else if (!this.contactspanel) {
                     this.$el.html(this.template(this.model.toJSON()));
-                    this.contactspanel = new converse.ContactsPanel({'$parent': this.$el.find('#controlbox-panes')});
+                    this.contactspanel = new converse.ContactsPanel({'$parent': this.$el.find('.controlbox-panes')});
                     this.contactspanel.render();
                     converse.xmppstatusview = new converse.XMPPStatusView({'model': converse.xmppstatus});
                     converse.xmppstatusview.render();

+ 2 - 2
spec/MainSpec.js

@@ -676,7 +676,7 @@
 
             it("contains two tabs, 'Contacts' and 'ChatRooms'", $.proxy(function () {
                 var cbview = this.chatboxesview.views.controlbox;
-                var $panels = cbview.$el.find('#controlbox-panes');
+                var $panels = cbview.$el.find('.controlbox-panes');
                 expect($panels.children().length).toBe(2);
                 expect($panels.children().first().attr('id')).toBe('users');
                 expect($panels.children().first().is(':visible')).toBe(true);
@@ -693,7 +693,7 @@
                 it("is opened by clicking the 'Chatrooms' tab", $.proxy(function () {
                     var cbview = this.chatboxesview.views.controlbox;
                     var $tabs = cbview.$el.find('#controlbox-tabs');
-                    var $panels = cbview.$el.find('#controlbox-panes');
+                    var $panels = cbview.$el.find('.controlbox-panes');
                     var $contacts = $panels.children().first();
                     var $chatrooms = $panels.children().last();
                     spyOn(cbview, 'switchTab').andCallThrough();