Преглед изворни кода

Changed the following:
- Subscribe event with help of jQuery one instead of delegate, now that
the rosterView is no longer emptied on every render to avoid
registring several handlers of remove action, which meant you had to
click 4 times for the jQuery Dialog to go away
- Remove the element from the rosterView when the remove event is
triggered on the model which removes just that item instead of
emptying the list and appending the remaining models again

ichim-david пре 12 година
родитељ
комит
85e9c7cecc
1 измењених фајлова са 4 додато и 2 уклоњено
  1. 4 2
      converse.js

+ 4 - 2
converse.js

@@ -1327,7 +1327,7 @@
             }
 
             // Event handlers
-            this.$el.delegate('a.remove-xmpp-contact','click', function (ev) {
+            this.$el.find('.remove-xmpp-contact').one('click', function (ev) {
                 ev.preventDefault();
                 that.removeContact();
             });
@@ -1608,8 +1608,10 @@
             }, this);
 
             this.model.on("remove", function (item) {
+                // remove element from the rosterView instance
+                this.rosteritemviews[item.id].$el.remove();
+                
                 delete this.rosteritemviews[item.id];
-                this.render(item);
             }, this);
 
             this.$el.hide();