Преглед изворни кода

Don't minimize chats by clicking the header

This prevents the burger menu from opening
JC Brand пре 4 година
родитељ
комит
8c799efc58
4 измењених фајлова са 3 додато и 6 уклоњено
  1. 2 2
      sass/_chatbox.scss
  2. 1 2
      spec/muc.js
  3. 0 1
      src/converse-chatview.js
  4. 0 1
      src/converse-muc-views.js

+ 2 - 2
sass/_chatbox.scss

@@ -447,7 +447,6 @@
             height: calc(100% - var(--overlayed-chat-head-height));
         }
         .chatbox-title {
-            cursor: pointer;
             padding: 0.5rem 0.75rem 0 0.75rem;
         }
         .chatbox-title--no-desc {
@@ -455,7 +454,8 @@
         }
         converse-dropdown {
             .btn--standalone {
-                padding: 0 0 0 0.5em;
+                padding: 0 0.2em;
+                margin: 0 0 0 0.5em;
             }
         }
     }

+ 1 - 2
spec/muc.js

@@ -681,8 +681,7 @@ describe("Groupchats", function () {
                 const toggle = view.el.querySelector('.hide-topic');
                 expect(toggle.textContent).toBe('Hide topic');
                 toggle.click();
-                await u.waitUntil(() => !u.isVisible(topic_el));
-                expect(view.el.querySelector('.hide-topic').textContent).toBe('Show topic');
+                await u.waitUntil(() => view.el.querySelector('.hide-topic').textContent === 'Show topic');
                 done();
             }));
 

+ 0 - 1
src/converse-chatview.js

@@ -172,7 +172,6 @@ converse.plugins.add('converse-chatview', {
 
             events: {
                 'click .chatbox-navback': 'showControlBox',
-                'click .chatbox-title': 'minimize',
                 'click .new-msgs-indicator': 'viewUnreadMessages',
                 'click .send-button': 'onFormSubmitted',
                 'click .toggle-clear': 'clearMessages',

+ 0 - 1
src/converse-muc-views.js

@@ -163,7 +163,6 @@ converse.plugins.add('converse-muc-views', {
             is_chatroom: true,
             events: {
                 'click .chatbox-navback': 'showControlBox',
-                'click .chatbox-title': 'minimize',
                 'click .hide-occupants': 'hideOccupants',
                 'click .new-msgs-indicator': 'viewUnreadMessages',
                 // Arrow functions don't work here because you can't bind a different `this` param to them.