Use optional chaining and update changelog

CHANGES.md

@@ -7,8 +7,8 @@
 - #2629: OMEMO button tooltip is wrong in private chat
 - #2633: Excessive logging of warning
 - #2634: Image previews not loading when not serving Converse locally
+- #2636: Don't fail when setting up a new XEP-0198 managed stream and `_converse.session` is undefined
 - Bugfix: Don't show minimized chats when logged out
-- Bugfix: Ensure that the converse session is actually present before trying to get things from it
 
 ## 8.0.0 (2021-09-03)
 

src/headless/plugins/smacks/utils.js

@@ -72,14 +72,13 @@ export function initSessionData () {
 }
 
 function resetSessionData () {
-    _converse.session &&
-        _converse.session.save({
-            'smacks_enabled': false,
-            'num_stanzas_handled': 0,
-            'num_stanzas_handled_by_server': 0,
-            'num_stanzas_since_last_ack': 0,
-            'unacked_stanzas': []
-        });
+    _converse.session?.save({
+        'smacks_enabled': false,
+        'num_stanzas_handled': 0,
+        'num_stanzas_handled_by_server': 0,
+        'num_stanzas_since_last_ack': 0,
+        'unacked_stanzas': []
+    });
 }
 
 function saveSessionData (el) {
@@ -196,7 +195,7 @@ export async function enableStreamManagement () {
     smacks_handlers.push(conn.addHandler(stanzaHandler));
     smacks_handlers.push(conn.addHandler(sendAck, Strophe.NS.SM, 'r'));
     smacks_handlers.push(conn.addHandler(handleAck, Strophe.NS.SM, 'a'));
-    if (_converse.session && _converse.session.get('smacks_stream_id')) {
+    if (_converse.session?.get('smacks_stream_id')) {
         await sendResumeStanza();
     } else {
         resetSessionData();