Browse Source

Remove `chatBoxOpened` event

JC Brand 6 years ago
parent
commit
94bea16cc4
4 changed files with 3 additions and 5 deletions
  1. 1 1
      spec/chatbox.js
  2. 2 2
      spec/messages.js
  3. 0 1
      src/converse-chatview.js
  4. 0 1
      src/converse-headline.js

+ 1 - 1
spec/chatbox.js

@@ -406,7 +406,7 @@
                 await test_utils.waitUntil(() => _converse.chatboxes.length == 7)
                 expect(_converse.chatboxviews.trimChats).toHaveBeenCalled();
                 expect(_converse.chatboxes.length).toEqual(7);
-                expect(_converse.api.trigger).toHaveBeenCalledWith('chatBoxOpened', jasmine.any(Object));
+                expect(_converse.api.trigger).toHaveBeenCalledWith('chatBoxInitialized', jasmine.any(Object));
                 test_utils.closeAllChatBoxes(_converse);
 
                 expect(_converse.chatboxes.length).toEqual(1);

+ 2 - 2
spec/messages.js

@@ -935,7 +935,7 @@
                     'id': (new Date()).getTime()
                 }).c('body').t('😇').up()
                 .c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
-            await new Promise(resolve => _converse.on('chatBoxOpened', resolve));
+            await new Promise(resolve => _converse.on('chatBoxInitialized', resolve));
             const view = _converse.api.chatviews.get(sender_jid);
             await new Promise((resolve, reject) => view.once('messageInserted', resolve));
 
@@ -1084,7 +1084,7 @@
                     'id': (new Date()).getTime()
                 }).c('body').t('A message').up()
                 .c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
-            await new Promise(resolve => _converse.on('chatBoxOpened', resolve));
+            await new Promise(resolve => _converse.on('chatBoxInitialized', resolve));
             const view = _converse.api.chatviews.get(sender_jid);
             await new Promise((resolve, reject) => view.once('messageInserted', resolve));
 

+ 0 - 1
src/converse-chatview.js

@@ -349,7 +349,6 @@ converse.plugins.add('converse-chatview', {
                 this.render();
 
                 this.fetchMessages();
-                _converse.api.trigger('chatBoxOpened', this); // TODO: remove
                 /**
                  * Triggered once the _converse.ChatBoxView has been initialized
                  * @event _converse#chatBoxInitialized

+ 0 - 1
src/converse-headline.js

@@ -89,7 +89,6 @@ converse.plugins.add('converse-headline', {
                 this.model.on('change:minimized', this.onMinimizedChanged, this);
 
                 this.render().insertHeading().fetchMessages().insertIntoDOM().hide();
-                _converse.api.trigger('chatBoxOpened', this); // TODO: remove
                 _converse.api.trigger('chatBoxInitialized', this);
             },