Ver código fonte

Don't rerender the text input when filtering contacts

JC Brand 8 anos atrás
pai
commit
9faf9c3d6f
2 arquivos alterados com 5 adições e 1 exclusões
  1. 1 0
      docs/CHANGES.md
  2. 4 1
      src/converse-rosterview.js

+ 1 - 0
docs/CHANGES.md

@@ -9,6 +9,7 @@
 - sinon 2.1.0
 - eslint 3.19.0
 
+- Don't rerender the text input when filtering contacts. [jcbrand]
 - Show the MUC server in a bookmarked room's info view (in the bookmarks list). [jcbrand]
 - Enable creation of `dist/converse-muc-embedded.js` build file for the
   embedded MUC room demo. [jcbrand]

+ 4 - 1
src/converse-rosterview.js

@@ -145,7 +145,7 @@
 
                 initialize: function () {
                     this.model.on('change:filter_type', this.render, this);
-                    this.model.on('change:filter_text', this.render, this);
+                    this.model.on('change:filter_text', this.renderClearButton, this);
                 },
 
                 render: function () {
@@ -169,6 +169,9 @@
 
                 renderClearButton: function () {
                     var roster_filter = this.el.querySelector('.roster-filter');
+                    if (_.isNull(roster_filter)) {
+                        return;
+                    }
                     roster_filter.classList[this.tog(roster_filter.value)]('x');
                 },