Ver Fonte

Add check inside method, like with playSoundNotification

JC Brand há 6 anos atrás
pai
commit
a2441545db
2 ficheiros alterados com 9 adições e 6 exclusões
  1. 5 3
      dist/converse.js
  2. 4 3
      src/converse-notification.js

+ 5 - 3
dist/converse.js

@@ -55787,6 +55787,10 @@ _converse_headless_converse_core__WEBPACK_IMPORTED_MODULE_0__["default"].plugins
       /* Shows an HTML5 Notification to indicate that a new chat
       /* Shows an HTML5 Notification to indicate that a new chat
        * message was received.
        * message was received.
        */
        */
+      if (!_converse.areDesktopNotificationsEnabled()) {
+        return;
+      }
+
       let title, roster_item;
       let title, roster_item;
       const full_from_jid = message.getAttribute('from'),
       const full_from_jid = message.getAttribute('from'),
             from_jid = Strophe.getBareJidFromJid(full_from_jid);
             from_jid = Strophe.getBareJidFromJid(full_from_jid);
@@ -55918,9 +55922,7 @@ _converse_headless_converse_core__WEBPACK_IMPORTED_MODULE_0__["default"].plugins
 
 
       _converse.playSoundNotification();
       _converse.playSoundNotification();
 
 
-      if (_converse.areDesktopNotificationsEnabled()) {
-        _converse.showMessageNotification(message);
-      }
+      _converse.showMessageNotification(message);
     };
     };
 
 
     _converse.handleContactRequestNotification = function (contact) {
     _converse.handleContactRequestNotification = function (contact) {

+ 4 - 3
src/converse-notification.js

@@ -138,6 +138,9 @@ converse.plugins.add('converse-notification', {
             /* Shows an HTML5 Notification to indicate that a new chat
             /* Shows an HTML5 Notification to indicate that a new chat
              * message was received.
              * message was received.
              */
              */
+            if (!_converse.areDesktopNotificationsEnabled()) {
+                return;
+            }
             let title, roster_item;
             let title, roster_item;
             const full_from_jid = message.getAttribute('from'),
             const full_from_jid = message.getAttribute('from'),
                   from_jid = Strophe.getBareJidFromJid(full_from_jid);
                   from_jid = Strophe.getBareJidFromJid(full_from_jid);
@@ -259,9 +262,7 @@ converse.plugins.add('converse-notification', {
                 return false;
                 return false;
             }
             }
             _converse.playSoundNotification();
             _converse.playSoundNotification();
-            if (_converse.areDesktopNotificationsEnabled()) {
-                _converse.showMessageNotification(message);
-            }
+            _converse.showMessageNotification(message);
         };
         };
 
 
         _converse.handleContactRequestNotification = function (contact) {
         _converse.handleContactRequestNotification = function (contact) {