Browse Source

Don't try to reconnect on auth fail.

JC Brand 9 years ago
parent
commit
a969d010cb
2 changed files with 10 additions and 8 deletions
  1. 7 0
      docs/source/development.rst
  2. 3 8
      src/converse-core.js

+ 7 - 0
docs/source/development.rst

@@ -873,6 +873,13 @@ When a chat buddy's custom status message has changed.
 
 ``converse.listen.on('contactStatusMessageChanged', function (event, data) { ... });``
 
+disconnected
+~~~~~~~~~~~~
+
+After converse.js has disconnected from the XMPP server.
+
+``converse.listen.on('disconnected', function (event) { ... });``
+
 initialized
 ~~~~~~~~~~~
 

+ 3 - 8
src/converse-core.js

@@ -440,15 +440,11 @@
 
         this.onDisconnected = function (condition) {
             if (!converse.auto_reconnect) { return; }
-            if (converse.disconnection_cause === Strophe.Status.CONNFAIL ||
-                    (converse.disconnection_cause === Strophe.Status.AUTHFAIL &&
-                     converse.credentials_url &&
-                     !converse.logged_out
-                    )
-                ) {
+            if (converse.disconnection_cause === Strophe.Status.CONNFAIL) {
                 converse.reconnect(condition);
                 return 'reconnecting';
             } else {
+                converse.emit('disconnected');
                 return 'disconnected';
             }
         };
@@ -551,7 +547,6 @@
         };
 
         this.logOut = function () {
-            converse.auto_login = false;
             converse.chatboxviews.closeAllChatBoxes();
             converse.clearSession();
             if (typeof converse.connection !== 'undefined') {
@@ -1650,7 +1645,7 @@
 
         this.autoLogin = function (credentials) {
             if (credentials) {
-                // If passed in, then they come from login_credentials, so we
+                // If passed in, then they come from credentials_url, so we
                 // set them on the converse object.
                 this.jid = credentials.jid;
                 this.password = credentials.password;