Browse Source

Move roster tests into their own module

JC Brand 7 years ago
parent
commit
b5e7bd5605
3 changed files with 3 additions and 1196 deletions
  1. 0 1194
      spec/controlbox.js
  2. 1 0
      tests/runner.js
  3. 2 2
      tests/utils.js

+ 0 - 1194
spec/controlbox.js

@@ -7,28 +7,6 @@
     var $iq = converse.env.$iq;
     var u = converse.env.utils;
 
-    var checkHeaderToggling = function ($group) {
-        var $toggle = $group.find('a.group-toggle');
-        expect(u.isVisible($group[0])).toBeTruthy();
-        expect($group.find('ul.collapsed').length).toBe(0);
-        expect($toggle.hasClass('icon-closed')).toBeFalsy();
-        expect($toggle.hasClass('icon-opened')).toBeTruthy();
-        $toggle.click();
-
-        return test_utils.waitUntil(function () {
-            return $group.find('ul.collapsed').length === 1;
-        }, 500).then(function () {
-            expect($toggle.hasClass('icon-closed')).toBeTruthy();
-            expect($toggle.hasClass('icon-opened')).toBeFalsy();
-            $toggle.click();
-            return test_utils.waitUntil(function () {
-                return $group.find('li').length === $group.find('li:visible').length
-            }, 500);
-        }).then(function () {
-            expect($toggle.hasClass('icon-closed')).toBeFalsy();
-            expect($toggle.hasClass('icon-opened')).toBeTruthy();
-        });
-    };
 
     describe("The Control Box", function () {
 
@@ -118,1178 +96,6 @@
         });
     });
 
-    describe("The Contacts Roster", function () {
-
-        describe("The live filter", function () {
-
-            it("will only appear when roster contacts flow over the visible area",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                var $filter = _converse.rosterview.$('.roster-filter');
-                var names = mock.cur_names;
-                test_utils.openControlBox();
-                _converse.rosterview.update(); // XXX: Will normally called as event handler
-                expect($filter.length).toBe(1);
-                test_utils.waitUntil(function () {
-                    return !$filter.is(':visible');
-                }).then(function () {
-                    for (var i=0; i<names.length; i++) {
-                        _converse.roster.create({
-                            ask: null,
-                            fullname: names[i],
-                            jid: names[i].replace(/ /g,'.').toLowerCase() + '@localhost',
-                            requesting: 'false',
-                            subscription: 'both'
-                        });
-                        _converse.rosterview.update(); // XXX: Will normally called as event handler
-                    }
-
-                    $.fn.hasScrollBar = function() {
-                        if (!$.contains(document, this.get(0))) {
-                            return false;
-                        }
-                        if(this.parent().height() < this.get(0).scrollHeight) {
-                            return true;
-                        }
-                        return false;
-                    };
-
-                    return test_utils.waitUntil(function () {
-                        if ($(_converse.rosterview.roster_el).hasScrollBar()) {
-                            return $filter.is(':visible');
-                        } else {
-                            return !$filter.is(':visible');
-                        }
-                    }).then(function () {
-                        done();
-                    });
-                });
-            }));
-
-            it("can be used to filter the contacts shown",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.roster_groups = true;
-                test_utils.openControlBox();
-                test_utils.createGroupedContacts(_converse);
-                var $filter = _converse.rosterview.$('.roster-filter');
-                var $roster = $(_converse.rosterview.roster_el);
-                _converse.rosterview.filter_view.delegateEvents();
-
-                var promise = test_utils.waitUntil(function () {
-                    return $roster.find('li:visible').length === 15;
-                }, 600).then(function (contacts) {
-                    expect($roster.find('ul.roster-group-contacts:visible').length).toBe(5);
-                    $filter.val("candice");
-                    $filter.trigger('keydown');
-
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('li:visible').length === 1;
-                    }, 600);
-                }).then(function (contacts) {
-                    // Only one roster contact is now visible
-                    expect($roster.find('li:visible').length).toBe(1);
-                    expect($roster.find('li:visible').eq(0).text().trim()).toBe('Candice van der Knijff');
-                    // Only one foster group is still visible
-                    expect($roster.find('.roster-group:visible').length).toBe(1);
-                    expect(_.trim($roster.find('.roster-group:visible a.group-toggle').eq(0).text())).toBe('colleagues');
-
-                    $filter = _converse.rosterview.$('.roster-filter');
-                    $filter.val("an");
-                    $filter.trigger('keydown');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('li:visible').length === 5;
-                    }, 600)
-                }).then(function (contacts) {
-                    // Five roster contact is now visible
-                    expect($roster.find('li:visible').length).toBe(5);
-                    // Four groups are still visible
-                    var $groups = $roster.find('.roster-group:visible a.group-toggle');
-                    expect($groups.length).toBe(4);
-                    expect(_.trim($groups.eq(0).text())).toBe('colleagues');
-                    expect(_.trim($groups.eq(1).text())).toBe('Family');
-                    expect(_.trim($groups.eq(2).text())).toBe('friends & acquaintences');
-                    expect(_.trim($groups.eq(3).text())).toBe('ænemies');
-
-                    $filter = _converse.rosterview.$('.roster-filter');
-                    $filter.val("xxx");
-                    $filter.trigger('keydown');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('li:visible').length === 0;
-                    }, 600)
-                }).then(function () {
-                    expect($roster.find('ul.roster-group-contacts:visible a.group-toggle').length).toBe(0);
-                    $filter = _converse.rosterview.$('.roster-filter');
-                    $filter.val("");  // Check that contacts are shown again, when the filter string is cleared.
-                    $filter.trigger('keydown');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('li:visible').length === 15;
-                    }, 600)
-                }).then(function () {
-                    expect($roster.find('ul.roster-group-contacts:visible').length).toBe(5);
-                    _converse.roster_groups = false;
-                    done();
-                });
-            }));
-
-            it("can be used to filter the groups shown",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                var $filter;
-                var $type;
-                _converse.roster_groups = true;
-                test_utils.openControlBox();
-                test_utils.createGroupedContacts(_converse);
-                _converse.rosterview.filter_view.delegateEvents();
-                $filter = _converse.rosterview.$('.roster-filter');
-                var $roster = $(_converse.rosterview.roster_el);
-                $type = _converse.rosterview.$('.filter-type');
-                $type.val('groups');
-                test_utils.waitUntil(function () {
-                    return $roster.find('li:visible').length === 15;
-                }, 600).then(function () {
-                    expect($roster.find('div.roster-group:visible a.group-toggle').length).toBe(5);
-
-                    $filter.val("colleagues");
-                    $filter.trigger('keydown');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('div.roster-group:not(.collapsed) a.group-toggle').length === 1;
-                    }, 600);
-                }).then(function () {
-                    expect(_.trim($roster.find('div.roster-group:not(.collapsed) a').eq(0).text())).toBe('colleagues');
-                    expect($roster.find('div.roster-group:not(.collapsed) li:visible').length).toBe(3);
-
-                    // Check that all contacts under the group are shown
-                    expect($roster.find('div.roster-group:not(.collapsed) li:hidden').length).toBe(0);
-
-                    $filter = _converse.rosterview.$('.roster-filter');
-                    $filter.val("xxx").trigger('keydown');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('div.roster-group.collapsed a.group-toggle').length === 5;
-                    }, 700);
-                }).then(function () {
-                    expect($roster.find('div.roster-group:not(.collapsed) a').length).toBe(0);
-
-                    $filter = _converse.rosterview.$('.roster-filter');
-                    $filter.val(""); // Check that groups are shown again, when the filter string is cleared.
-                    $filter.trigger('keydown');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('div.roster-group.collapsed a.group-toggle').length === 0;
-                    }, 600);
-                }).then(function () {
-                    expect($roster.find('div.roster-group:not(collapsed)').length).toBe(5);
-                    expect($roster.find('div.roster-group:not(collapsed) li').length).toBe(15);
-                    done();
-                });
-            }));
-
-            it("has a button with which its contents can be cleared",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.roster_groups = true;
-                test_utils.openControlBox();
-                test_utils.createGroupedContacts(_converse);
-                var $filter = _converse.rosterview.$('.roster-filter');
-                _converse.rosterview.filter_view.delegateEvents();
-                $filter.val("xxx");
-                $filter.trigger('keydown');
-                expect($filter.hasClass("x")).toBeFalsy();
-                $filter = _converse.rosterview.$('.roster-filter');
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$('.roster-filter').hasClass("x");
-                }, 900).then(function () {
-                    var $filter = _converse.rosterview.$('.roster-filter');
-                    $filter.addClass("onX").click();
-                    return test_utils.waitUntil(function () {
-                        return !_converse.rosterview.$('.roster-filter').hasClass("x");
-                    }, 900)
-                }).then(function () {
-                    expect(document.querySelector('.roster-filter').value).toBe("");
-                    done();
-                });
-            }));
-
-            it("can be used to filter contacts by their chat state",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                var $filter;
-                _converse.roster_groups = true;
-                test_utils.createGroupedContacts(_converse);
-                var jid = mock.cur_names[3].replace(/ /g,'.').toLowerCase() + '@localhost';
-                _converse.roster.get(jid).set('chat_status', 'online');
-                test_utils.openControlBox();
-
-                _converse.rosterview.filter_view.delegateEvents();
-                var $type = _converse.rosterview.$('.filter-type');
-                $type.val('state').trigger('change');
-                $filter = _converse.rosterview.$('.state-type');
-                var $roster = $(_converse.rosterview.roster_el);
-
-                test_utils.waitUntil(function () {
-                        return $roster.find('li:visible').length === 15;
-                }, 500).then(function () {
-                    expect($roster.find('ul.roster-group-contacts:visible').length).toBe(5);
-                    $filter.val("online");
-                    $filter.trigger('change');
-                    return test_utils.waitUntil(function () {
-                        return $roster.find('li:visible').length === 1;
-                    }, 500)
-                }).then(function () {
-                    expect($roster.find('li:visible').eq(0).text().trim()).toBe('Rinse Sommer');
-                    expect($roster.find('ul.roster-group-contacts:visible').length).toBe(1);
-                    var $type = _converse.rosterview.$('.filter-type');
-                    $type.val('contacts').trigger('change');
-                    done();
-                });
-            }));
-        });
-
-        describe("A Roster Group", function () {
-
-            it("can be used to organize existing contacts",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.roster_groups = true;
-                spyOn(_converse, 'emit');
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                _converse.rosterview.render();
-                test_utils.openControlBox();
-                test_utils.createContacts(_converse, 'pending');
-                test_utils.createContacts(_converse, 'requesting');
-                test_utils.createGroupedContacts(_converse);
-                // Check that the groups appear alphabetically and that
-                // requesting and pending contacts are last.
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group:visible a.group-toggle').length;
-                }, 500).then(function () {
-                    var group_titles = $.map(
-                        _converse.rosterview.$el.find('.roster-group:visible a.group-toggle'),
-                        function (o) { return $(o).text().trim(); }
-                    );
-                    expect(group_titles).toEqual([
-                        "Contact requests",
-                        "colleagues",
-                        "Family",
-                        "friends & acquaintences",
-                        "ænemies",
-                        "Ungrouped",
-                        "Pending contacts"
-                    ]);
-                    // Check that usernames appear alphabetically per group
-                    _.each(_.keys(mock.groups), function (name) {
-                        var $contacts = _converse.rosterview.$('.roster-group[data-group="'+name+'"] ul');
-                        var names = $.map($contacts, function (o) { return $(o).text().trim(); });
-                        expect(names).toEqual(_.clone(names).sort());
-                    });
-                    done();
-                });
-            }));
-
-            it("can share contacts with other roster groups", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.roster_groups = true;
-                var groups = ['colleagues', 'friends'];
-                spyOn(_converse, 'emit');
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                test_utils.openControlBox();
-                _converse.rosterview.render();
-                for (var i=0; i<mock.cur_names.length; i++) {
-                    _converse.roster.create({
-                        jid: mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost',
-                        subscription: 'both',
-                        ask: null,
-                        groups: groups,
-                        fullname: mock.cur_names[i]
-                    });
-                }
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('li:visible').length === 30;
-                }, 600).then(function () {
-                    // Check that usernames appear alphabetically per group
-                    _.each(groups, function (name) {
-                        var $contacts = _converse.rosterview.$('.roster-group[data-group="'+name+'"] li');
-                        var names = $.map($contacts, function (o) { return $(o).text().trim(); });
-                        expect(names).toEqual(_.clone(names).sort());
-                        expect(names.length).toEqual(mock.cur_names.length);
-                    });
-                    done();
-                });
-            }));
-
-            it("remembers whether it is closed or opened",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.roster_groups = true;
-                test_utils.openControlBox();
-
-                var i=0, j=0;
-                var groups = {
-                    'colleagues': 3,
-                    'friends & acquaintences': 3,
-                    'Ungrouped': 2
-                };
-                _.each(_.keys(groups), function (name) {
-                    j = i;
-                    for (i=j; i<j+groups[name]; i++) {
-                        _converse.roster.create({
-                            jid: mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost',
-                            subscription: 'both',
-                            ask: null,
-                            groups: name === 'ungrouped'? [] : [name],
-                            fullname: mock.cur_names[i]
-                        });
-                    }
-                });
-                var view = _converse.rosterview.get('colleagues');
-                var $toggle = view.$el.find('a.group-toggle');
-                expect(view.model.get('state')).toBe('opened');
-                $toggle.click();
-                return test_utils.waitUntil(function () {
-                    return view.model.get('state') === 'closed';
-                }, 500).then(function () {
-                    $toggle.click();
-                    return test_utils.waitUntil(function () {
-                        return view.model.get('state') === 'opened';
-                    }, 500)
-                }).then(function () {
-                    done();
-                });
-            }));
-        });
-
-        describe("Pending Contacts", function () {
-
-            function _addContacts (_converse) {
-                // Must be initialized, so that render is called and documentFragment set up.
-                test_utils.createContacts(_converse, 'pending');
-                test_utils.openControlBox();
-                test_utils.openContactsPanel(_converse);
-            }
-
-            it("can be collapsed under their own header", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('li').length;
-                }, 500).then(function () {
-                    checkHeaderToggling.apply(
-                        _converse,
-                        [_converse.rosterview.get('Pending contacts').$el]
-                    ).then(done);
-                });
-            }));
-
-            it("can be added to the roster",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                spyOn(_converse, 'emit');
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                test_utils.openControlBox();
-                _converse.roster.create({
-                    jid: mock.pend_names[0].replace(/ /g,'.').toLowerCase() + '@localhost',
-                    subscription: 'none',
-                    ask: 'subscribe',
-                    fullname: mock.pend_names[0]
-                });
-                expect(_converse.rosterview.update).toHaveBeenCalled();
-                done();
-            }));
-
-            it("are shown in the roster when show_only_online_users", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.show_only_online_users = true;
-                test_utils.openControlBox();
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('li').length;
-                }, 700).then(function () {
-                    expect(_converse.rosterview.$el.is(':visible')).toEqual(true);
-                    expect(_converse.rosterview.update).toHaveBeenCalled();
-                    expect(_converse.rosterview.$el.find('li:visible').length).toBe(3);
-                    expect(_converse.rosterview.$el.find('ul.roster-group-contacts:visible').length).toBe(1);
-                    done();
-                });
-            }));
-
-            it("are shown in the roster when hide_offline_users", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.hide_offline_users = true;
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('li:visible').length;
-                    }, 500)
-                .then(function () {
-                    expect(_converse.rosterview.update).toHaveBeenCalled();
-                    expect(_converse.rosterview.$el.is(':visible')).toBe(true);
-                    expect(_converse.rosterview.$el.find('li:visible').length).toBe(3);
-                    expect(_converse.rosterview.$el.find('ul.roster-group-contacts:visible').length).toBe(1);
-                    done();
-                });
-            }));
-
-            it("can be removed by the user", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                var name = mock.pend_names[0];
-                var jid = name.replace(/ /g,'.').toLowerCase() + '@localhost';
-                var contact = _converse.roster.get(jid);
-
-                spyOn(window, 'confirm').and.returnValue(true);
-                spyOn(contact, 'unauthorize').and.callFake(function () { return contact; });
-                spyOn(contact, 'removeFromRoster');
-                spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
-                    if (typeof callback === "function") { return callback(); }
-                });
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find(".pending-contact-name:contains('"+name+"')").length;
-                }, 700).then(function () {
-                    _converse.rosterview.$el.find(".pending-contact-name:contains('"+name+"')")
-                        .parent().siblings('.remove-xmpp-contact').click();
-                    return test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find(".pending-contact-name:contains('"+name+"')").length === 0
-                    }, 700)
-                }).then(function () {
-                    expect(window.confirm).toHaveBeenCalled();
-                    expect(_converse.connection.sendIQ).toHaveBeenCalled();
-                    expect(contact.removeFromRoster).toHaveBeenCalled();
-                    expect(_converse.connection.sendIQ).toHaveBeenCalled();
-                    done();
-                });
-            }));
-
-            it("do not have a header if there aren't any", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.openControlBox();
-                var name = mock.pend_names[0];
-                _converse.roster.create({
-                    jid: name.replace(/ /g,'.').toLowerCase() + '@localhost',
-                    subscription: 'none',
-                    ask: 'subscribe',
-                    fullname: name
-                });
-                spyOn(window, 'confirm').and.returnValue(true);
-                spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
-                    if (typeof callback === "function") { return callback(); }
-                });
-                test_utils.waitUntil(function () {
-                        var $pending_contacts = _converse.rosterview.get('Pending contacts').$el;
-                        return $pending_contacts.is(':visible') && $pending_contacts.find('li:visible').length;
-                }, 700).then(function () {
-                    _converse.rosterview.$el.find(".pending-contact-name:contains('"+name+"')")
-                        .parent().siblings('.remove-xmpp-contact').click();
-                    expect(window.confirm).toHaveBeenCalled();
-                    expect(_converse.connection.sendIQ).toHaveBeenCalled();
-                    expect(_converse.rosterview.get('Pending contacts').$el.is(':visible')).toEqual(false);
-                    done();
-                });
-            }));
-
-            it("is shown when a new private message is received",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                var name;
-                spyOn(window, 'confirm').and.returnValue(true);
-                for (var i=0; i<mock.pend_names.length; i++) {
-                    name = mock.pend_names[i];
-                    _converse.rosterview.$el.find(".pending-contact-name:contains('"+name+"')")
-                        .parent().siblings('.remove-xmpp-contact').click();
-                }
-                expect(_converse.rosterview.$el.find('#pending-xmpp-contacts').is(':visible')).toBeFalsy();
-                done();
-            }));
-
-            it("can be added to the roster and they will be sorted alphabetically",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                var i, t;
-                test_utils.openControlBox();
-                spyOn(_converse, 'emit');
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                for (i=0; i<mock.pend_names.length; i++) {
-                    _converse.roster.create({
-                        jid: mock.pend_names[i].replace(/ /g,'.').toLowerCase() + '@localhost',
-                        subscription: 'none',
-                        ask: 'subscribe',
-                        fullname: mock.pend_names[i]
-                    });
-                    expect(_converse.rosterview.update).toHaveBeenCalled();
-                }
-                return test_utils.waitUntil(function () {
-                    return _converse.rosterview.get('Pending contacts').$el.find('li:visible').length;
-                }, 700).then(function () {
-                    // Check that they are sorted alphabetically
-                    t = _.reduce(_converse.rosterview.get('Pending contacts').$el.find('.pending-xmpp-contact span'),
-                        function (result, value) {
-                            return result + _.trim(value.textContent);
-                        }, '');
-                    expect(t).toEqual(mock.pend_names.slice(0,i+1).sort().join(''));
-                    done();
-                });
-            }));
-        });
-
-        describe("Existing Contacts", function () {
-            var _addContacts = function (_converse) {
-                test_utils.createContacts(_converse, 'current')
-                    .openControlBox()
-                    .openContactsPanel(_converse);
-            };
-
-            it("can be collapsed under their own header", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('li:visible').length;
-                }, 500).then(function () {
-                    checkHeaderToggling.apply(
-                        _converse,
-                        [_converse.rosterview.$el.find('.roster-group')]
-                    ).then(done);
-                });
-            }));
-
-            it("will be hidden when appearing under a collapsed group", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _converse.roster_groups = false;
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('li:visible').length;
-                    }, 500)
-                .then(function () {
-                    _converse.rosterview.$el.find('.roster-group a.group-toggle').click();
-                    var name = "Max Mustermann";
-                    var jid = name.replace(/ /g,'.').toLowerCase() + '@localhost';
-                    _converse.roster.create({
-                        ask: null,
-                        fullname: name,
-                        jid: jid,
-                        requesting: false,
-                        subscription: 'both'
-                    });
-                    var view = _converse.rosterview.get('My contacts').get(jid);
-                    expect(view.$el.is(':visible')).toBe(false);
-                    done();
-                });
-            }));
-
-            it("can be added to the roster and they will be sorted alphabetically", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.openControlBox();
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                for (var i=0; i<mock.cur_names.length; i++) {
-                    _converse.roster.create({
-                        jid: mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost',
-                        subscription: 'both',
-                        ask: null,
-                        fullname: mock.cur_names[i]
-                    });
-                    expect(_converse.rosterview.update).toHaveBeenCalled();
-                }
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('li').length;
-                }, 600).then(function () {
-                    // Check that they are sorted alphabetically
-                    var t = _.reduce(_converse.rosterview.$('.roster-group')
-                             .find('.current-xmpp-contact.offline a.open-chat'),
-                        function (result, value) {
-                            return result + _.trim(value.textContent);
-                        }, '');
-                    expect(t).toEqual(mock.cur_names.slice(0,i+1).sort().join(''));
-                    done();
-                });
-            }));
-
-            it("can be removed by the user", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('li').length;
-                }, 500).then(function () {
-                    var name = mock.cur_names[0];
-                    var jid = name.replace(/ /g,'.').toLowerCase() + '@localhost';
-                    var contact = _converse.roster.get(jid);
-                    spyOn(window, 'confirm').and.returnValue(true);
-                    spyOn(contact, 'removeFromRoster');
-                    spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
-                        if (typeof callback === "function") { return callback(); }
-                    });
-                    _converse.rosterview.$el.find(".open-chat:contains('"+name+"')")
-                        .parent().find('.remove-xmpp-contact').click();
-
-                    expect(window.confirm).toHaveBeenCalled();
-                    expect(_converse.connection.sendIQ).toHaveBeenCalled();
-                    expect(contact.removeFromRoster).toHaveBeenCalled();
-                    expect(_converse.rosterview.$el.find(".open-chat:contains('"+name+"')").length).toEqual(0);
-                    done();
-                });
-            }));
-
-            it("do not have a header if there aren't any", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                var name = mock.cur_names[0];
-                var contact;
-                contact = _converse.roster.create({
-                    jid: name.replace(/ /g,'.').toLowerCase() + '@localhost',
-                    subscription: 'both',
-                    ask: null,
-                    fullname: name
-                });
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    spyOn(window, 'confirm').and.returnValue(true);
-                    spyOn(contact, 'removeFromRoster');
-                    spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
-                        if (typeof callback === "function") { return callback(); }
-                    });
-
-                    expect(_converse.rosterview.$el.find('.roster-group').css('display')).toEqual('block');
-                    _converse.rosterview.$el.find(".open-chat:contains('"+name+"')")
-                        .parent().find('.remove-xmpp-contact').click();
-                    expect(window.confirm).toHaveBeenCalled();
-                    expect(_converse.connection.sendIQ).toHaveBeenCalled();
-                    expect(contact.removeFromRoster).toHaveBeenCalled();
-                    expect(_converse.rosterview.$el.find('.roster-group').css('display')).toEqual('none');
-                    done();
-                });
-            }));
-
-            it("can change their status to online and be sorted alphabetically", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    var jid, t;
-                    spyOn(_converse, 'emit');
-                    spyOn(_converse.rosterview, 'update').and.callThrough();
-                    var $roster = _converse.rosterview.$el;
-                    for (var i=0; i<mock.cur_names.length; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'online');
-                        expect(_converse.rosterview.update).toHaveBeenCalled();
-                        // Check that they are sorted alphabetically
-                        t = _.reduce($roster.find('.roster-group').find('.current-xmpp-contact.online a.open-chat'), function (result, value) {
-                            return result + _.trim(value.textContent);
-                        }, '');
-                        expect(t).toEqual(mock.cur_names.slice(0,i+1).sort().join(''));
-                    }
-                    done();
-                });
-            }));
-
-            it("can change their status to busy and be sorted alphabetically", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    var jid, t;
-                    spyOn(_converse, 'emit');
-                    spyOn(_converse.rosterview, 'update').and.callThrough();
-                    var $roster = _converse.rosterview.$el;
-                    for (var i=0; i<mock.cur_names.length; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'dnd');
-                        expect(_converse.rosterview.update).toHaveBeenCalled();
-                        // Check that they are sorted alphabetically
-                        t = _.reduce($roster.find('.roster-group .current-xmpp-contact.dnd a.open-chat'),
-                            function (result, value) {
-                                return result + _.trim(value.textContent);
-                            }, '');
-                        expect(t).toEqual(mock.cur_names.slice(0,i+1).sort().join(''));
-                    }
-                    done();
-                });
-            }));
-
-            it("can change their status to away and be sorted alphabetically", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    var jid, t;
-                    spyOn(_converse, 'emit');
-                    spyOn(_converse.rosterview, 'update').and.callThrough();
-                    var $roster = _converse.rosterview.$el;
-                    for (var i=0; i<mock.cur_names.length; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'away');
-                        expect(_converse.rosterview.update).toHaveBeenCalled();
-                        // Check that they are sorted alphabetically
-                        t = _.reduce($roster.find('.roster-group .current-xmpp-contact.away a.open-chat'),
-                            function (result, value) {
-                                return result + _.trim(value.textContent);
-                            }, '');
-                        expect(t).toEqual(mock.cur_names.slice(0,i+1).sort().join(''));
-                    }
-                    done();
-                });
-            }));
-
-            it("can change their status to xa and be sorted alphabetically", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    var jid, t;
-                    spyOn(_converse, 'emit');
-                    spyOn(_converse.rosterview, 'update').and.callThrough();
-                    var $roster = _converse.rosterview.$el;
-                    for (var i=0; i<mock.cur_names.length; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'xa');
-                        expect(_converse.rosterview.update).toHaveBeenCalled();
-                        // Check that they are sorted alphabetically
-                        t = _.reduce($roster.find('.roster-group .current-xmpp-contact.xa a.open-chat'),
-                            function (result, value) {
-                                return result + _.trim(value.textContent);
-                            }, '');
-                        expect(t).toEqual(mock.cur_names.slice(0,i+1).sort().join(''));
-                    }
-                    done();
-                });
-            }));
-
-            it("can change their status to unavailable and be sorted alphabetically", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('.roster-group li').length;
-                    }, 500)
-                .then(function () {
-                    var jid, t;
-                    spyOn(_converse, 'emit');
-                    spyOn(_converse.rosterview, 'update').and.callThrough();
-                    var $roster = _converse.rosterview.$el;
-                    for (var i=0; i<mock.cur_names.length; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'unavailable');
-                        expect(_converse.rosterview.update).toHaveBeenCalled();
-                        // Check that they are sorted alphabetically
-                        t = _.reduce($roster.find('.roster-group .current-xmpp-contact.unavailable a.open-chat'),
-                            function (result, value) {
-                                return result + _.trim(value.textContent);
-                            }, '');
-                        expect(t).toEqual(mock.cur_names.slice(0,i+1).sort().join(''));
-                    }
-                    done();
-                });
-            }));
-
-            it("are ordered according to status: online, busy, away, xa, unavailable, offline", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                _addContacts(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    var i, jid;
-                    for (i=0; i<3; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'online');
-                    }
-                    for (i=3; i<6; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'dnd');
-                    }
-                    for (i=6; i<9; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'away');
-                    }
-                    for (i=9; i<12; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'xa');
-                    }
-                    for (i=12; i<15; i++) {
-                        jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@localhost';
-                        _converse.roster.get(jid).set('chat_status', 'unavailable');
-                    }
-                    return test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('li.online').length
-                    })
-                }).then(function () {
-                    return test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('li:first').text().trim() === 'Candice van der Knijff'
-                    }, 900);
-                }).then(function () {
-                    var i;
-                    var contacts = _converse.rosterview.$el.find('.current-xmpp-contact');
-                    for (i=0; i<3; i++) {
-                        expect($(contacts[i]).hasClass('online')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('both')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('dnd')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('away')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('xa')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('unavailable')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('offline')).toBeFalsy();
-                    }
-                    for (i=3; i<6; i++) {
-                        expect($(contacts[i]).hasClass('dnd')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('both')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('online')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('away')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('xa')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('unavailable')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('offline')).toBeFalsy();
-                    }
-                    for (i=6; i<9; i++) {
-                        expect($(contacts[i]).hasClass('away')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('both')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('online')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('dnd')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('xa')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('unavailable')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('offline')).toBeFalsy();
-                    }
-                    for (i=9; i<12; i++) {
-                        expect($(contacts[i]).hasClass('xa')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('both')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('online')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('dnd')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('away')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('unavailable')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('offline')).toBeFalsy();
-                    }
-                    for (i=12; i<15; i++) {
-                        expect($(contacts[i]).hasClass('unavailable')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('both')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('online')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('dnd')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('away')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('xa')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('offline')).toBeFalsy();
-                    }
-                    for (i=15; i<mock.cur_names.length; i++) {
-                        expect($(contacts[i]).hasClass('offline')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('both')).toBeTruthy();
-                        expect($(contacts[i]).hasClass('online')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('dnd')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('away')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('xa')).toBeFalsy();
-                        expect($(contacts[i]).hasClass('unavailable')).toBeFalsy();
-                    }
-                    done();
-                });
-            }));
-        });
-
-        describe("Requesting Contacts", function () {
-
-            it("can be added to the roster and they will be sorted alphabetically",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                var i, children;
-                var names = [];
-                var addName = function (idx, item) {
-                    if (!$(item).hasClass('request-actions')) {
-                        names.push($(item).text().replace(/^\s+|\s+$/g, ''));
-                    }
-                };
-                test_utils.openContactsPanel(_converse);
-                spyOn(_converse, 'emit');
-                spyOn(_converse.rosterview, 'update').and.callThrough();
-                spyOn(_converse.controlboxtoggle, 'showControlBox').and.callThrough();
-                for (i=0; i<mock.req_names.length; i++) {
-                    _converse.roster.create({
-                        jid: mock.req_names[i].replace(/ /g,'.').toLowerCase() + '@localhost',
-                        subscription: 'none',
-                        ask: null,
-                        requesting: true,
-                        fullname: mock.req_names[i]
-                    });
-                }
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.get('Contact requests').$el.find('li').length;
-                }, 700).then(function () {
-                    expect(_converse.rosterview.update).toHaveBeenCalled();
-                    // Check that they are sorted alphabetically
-                    children = _converse.rosterview.get('Contact requests').$el.find('.requesting-xmpp-contact span');
-                    names = [];
-                    children.each(addName);
-                    expect(names.join('')).toEqual(mock.req_names.slice(0,mock.req_names.length+1).sort().join(''));
-                    done();
-                });
-            }));
-
-            it("do not have a header if there aren't any", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.openContactsPanel(_converse);
-                var name = mock.req_names[0];
-                spyOn(window, 'confirm').and.returnValue(true);
-                _converse.roster.create({
-                    jid: name.replace(/ /g,'.').toLowerCase() + '@localhost',
-                    subscription: 'none',
-                    ask: null,
-                    requesting: true,
-                    fullname: name
-                });
-                test_utils.waitUntil(function () {
-                        return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    expect(_converse.rosterview.get('Contact requests').$el.is(':visible')).toEqual(true);
-                    _converse.rosterview.$el.find(".req-contact-name:contains('"+name+"')")
-                        .parent().siblings('.request-actions')
-                        .find('.decline-xmpp-request').click();
-                    expect(window.confirm).toHaveBeenCalled();
-                    expect(_converse.rosterview.get('Contact requests').$el.is(':visible')).toEqual(false);
-                    done();
-                });
-            }));
-
-            it("can be collapsed under their own header", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.createContacts(_converse, 'requesting').openControlBox();
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    checkHeaderToggling.apply(
-                        _converse,
-                        [_converse.rosterview.get('Contact requests').$el]
-                    ).then(done);
-                });
-            }));
-
-            it("can have their requests accepted by the user", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.createContacts(_converse, 'requesting').openControlBox();
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    // TODO: Testing can be more thorough here, the user is
-                    // actually not accepted/authorized because of
-                    // mock_connection.
-                    var name = mock.req_names.sort()[0];
-                    var jid =  name.replace(/ /g,'.').toLowerCase() + '@localhost';
-                    var contact = _converse.roster.get(jid);
-                    spyOn(_converse.roster, 'sendContactAddIQ').and.callFake(function (jid, fullname, groups, callback) {
-                        callback();
-                    });
-                    spyOn(contact, 'authorize').and.callFake(function () { return contact; });
-                    _converse.rosterview.$el.find(".req-contact-name:contains('"+name+"')")
-                        .parent().siblings('.request-actions')
-                        .find('.accept-xmpp-request').click();
-                    expect(_converse.roster.sendContactAddIQ).toHaveBeenCalled();
-                    expect(contact.authorize).toHaveBeenCalled();
-                    done();
-                });
-            }));
-
-            it("can have their requests denied by the user", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.createContacts(_converse, 'requesting').openControlBox();
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    _converse.rosterview.update(); // XXX: Hack to make sure $roster element is attaced.
-                    var name = mock.req_names.sort()[1];
-                    var jid =  name.replace(/ /g,'.').toLowerCase() + '@localhost';
-                    var contact = _converse.roster.get(jid);
-                    spyOn(window, 'confirm').and.returnValue(true);
-                    spyOn(contact, 'unauthorize').and.callFake(function () { return contact; });
-                    _converse.rosterview.$el.find(".req-contact-name:contains('"+name+"')")
-                        .parent().siblings('.request-actions')
-                        .find('.decline-xmpp-request').click();
-                    expect(window.confirm).toHaveBeenCalled();
-                    expect(contact.unauthorize).toHaveBeenCalled();
-                    // There should now be one less contact
-                    expect(_converse.roster.length).toEqual(mock.req_names.length-1);
-                    done();
-                });
-            }));
-
-            it("are persisted even if other contacts' change their presence ", mock.initConverseWithPromises(
-                null, ['rosterGroupsFetched'], {}, function (done, _converse) {
-
-                /* This is a regression test.
-                 * https://github.com/jcbrand/_converse.js/issues/262
-                 */
-                expect(_converse.roster.pluck('jid').length).toBe(0);
-
-                var stanza = $pres({from: 'data@enterprise/resource', type: 'subscribe'});
-                _converse.connection._dataRecv(test_utils.createRequest(stanza));
-                test_utils.waitUntil(function () {
-                    return $('a:contains("Contact requests")').length;
-                }, 700).then(function () {
-                    expect(_converse.roster.pluck('jid').length).toBe(1);
-                    expect(_.includes(_converse.roster.pluck('jid'), 'data@enterprise')).toBeTruthy();
-                    // Taken from the spec
-                    // http://xmpp.org/rfcs/rfc3921.html#rfc.section.7.3
-                    stanza = $iq({
-                        to: _converse.connection.jid,
-                        type: 'result',
-                        id: 'roster_1'
-                    }).c('query', {
-                        xmlns: 'jabber:iq:roster',
-                    }).c('item', {
-                        jid: 'romeo@example.net',
-                        name: 'Romeo',
-                        subscription:'both'
-                    }).c('group').t('Friends').up().up()
-                    .c('item', {
-                        jid: 'mercutio@example.org',
-                        name: 'Mercutio',
-                        subscription:'from'
-                    }).c('group').t('Friends').up().up()
-                    .c('item', {
-                        jid: 'benvolio@example.org',
-                        name: 'Benvolio',
-                        subscription:'both'
-                    }).c('group').t('Friends');
-                    _converse.roster.onReceivedFromServer(stanza.tree());
-                    expect(_.includes(_converse.roster.pluck('jid'), 'data@enterprise')).toBeTruthy();
-                    done();
-                });
-            }));
-        });
-
-        describe("All Contacts", function () {
-
-            it("are saved to, and can be retrieved from browserStorage",
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.createContacts(_converse, 'all').openControlBox();
-                test_utils.openContactsPanel(_converse);
-                var new_attrs, old_attrs, attrs;
-                var num_contacts = _converse.roster.length;
-                var new_roster = new _converse.RosterContacts();
-                // Roster items are yet to be fetched from browserStorage
-                expect(new_roster.length).toEqual(0);
-                new_roster.browserStorage = _converse.roster.browserStorage;
-                new_roster.fetch();
-                expect(new_roster.length).toEqual(num_contacts);
-                // Check that the roster items retrieved from browserStorage
-                // have the same attributes values as the original ones.
-                attrs = ['jid', 'fullname', 'subscription', 'ask'];
-                for (var i=0; i<attrs.length; i++) {
-                    new_attrs = _.map(_.map(new_roster.models, 'attributes'), attrs[i]);
-                    old_attrs = _.map(_.map(_converse.roster.models, 'attributes'), attrs[i]);
-                    // Roster items in storage are not necessarily sorted,
-                    // so we have to sort them here to do a proper
-                    // comparison
-                    expect(_.isEqual(new_attrs.sort(), old_attrs.sort())).toEqual(true);
-                }
-                done();
-            }));
-
-            it("will show fullname and jid properties on tooltip", 
-                mock.initConverseWithPromises(
-                    null, ['rosterGroupsFetched'], {},
-                    function (done, _converse) {
-
-                test_utils.createContacts(_converse, 'all').openControlBox();
-                test_utils.openContactsPanel(_converse);
-                test_utils.waitUntil(function () {
-                    return _converse.rosterview.$el.find('.roster-group li').length;
-                }, 700).then(function () {
-                    var jid, name, i;
-                    for (i=0; i<mock.cur_names.length; i++) {
-                        name = mock.cur_names[i];
-                        jid = name.replace(/ /g,'.').toLowerCase() + '@localhost';
-                        var $dd = _converse.rosterview.$el.find("li:contains('"+name+"')").children().first();
-                        var dd_text = $dd.text();
-                        var dd_title = $dd.attr('title');
-                        expect(_.trim(dd_text)).toBe(name);
-                        expect(dd_title).toContain(name);
-                        expect(dd_title).toContain(jid);
-                    }
-                    done();
-                });
-            }));
-        });
-    });
-
     describe("The 'Add Contact' widget", function () {
 
         it("opens up an add form when you click on it",

+ 1 - 0
tests/runner.js

@@ -46,6 +46,7 @@ var specs = [
     "spec/mam",
     "spec/otr",
     "spec/controlbox",
+    "spec/roster",
     "spec/chatbox",
     "spec/chatroom",
     "spec/minchats",

+ 2 - 2
tests/utils.js

@@ -228,7 +228,7 @@
         /* Create grouped contacts
          */
         var i=0, j=0;
-        _.each(_.keys(mock.groups), $.proxy(function (name) {
+        _.each(_.keys(mock.groups), function (name) {
             j = i;
             for (i=j; i<j+mock.groups[name]; i++) {
                 converse.roster.create({
@@ -239,7 +239,7 @@
                     fullname: mock.cur_names[i]
                 });
             }
-        }, converse));
+        });
     };
 
     utils.createChatMessage = function (_converse, sender_jid, message) {