Kaynağa Gözat

bugfix in positionGroup.

Index must always be 0 if there aren't any group elements in the dom yet.
JC Brand 10 yıl önce
ebeveyn
işleme
d03a9a0192
2 değiştirilmiş dosya ile 4 ekleme ve 3 silme
  1. 3 2
      converse.js
  2. 1 1
      spec/profiling.js

+ 3 - 2
converse.js

@@ -4077,13 +4077,14 @@
                 /* Place the group's DOM element in the correct alphabetical
                  * position amongst the other groups in the roster.
                  */
-                var index = this.model.indexOf(view.model);
+                var $groups = this.$('.roster-group'),
+                    index = $groups.length ? this.model.indexOf(view.model) : 0;
                 if (index === 0) {
                     this.$roster.prepend(view.$el);
                 } else if (index == (this.model.length-1)) {
                     this.appendGroup(view);
                 } else {
-                    $(this.$('.roster-group').eq(index)).before(view.$el);
+                    $($groups.eq(index)).before(view.$el);
                 }
                 return this;
             },

+ 1 - 1
spec/profiling.js

@@ -53,7 +53,7 @@
             });
             _.each(['Friends', 'Colleagues', 'Family', 'Acquaintances'], function (group) {
                 var i;
-                for (i=0; i<500; i++) {
+                for (i=0; i<100; i++) {
                     stanza = stanza.c('item', {
                         jid: Math.random().toString().replace('0.', '')+'@example.net',
                         subscription:'both'