소스 검색

roomslist: Room name wasn't being shown in `confirm` dialog

JC Brand 8 년 전
부모
커밋
dc7249f07d
2개의 변경된 파일7개의 추가작업 그리고 3개의 파일을 삭제
  1. 1 1
      spec/roomslist.js
  2. 6 2
      src/templates/rooms_list_item.html

+ 1 - 1
spec/roomslist.js

@@ -75,7 +75,7 @@
             var close_el = _converse.rooms_list_view.el.querySelector(".close-room");
             close_el.click();
             expect(window.confirm).toHaveBeenCalledWith(
-                'Are you sure you want to leave the room ""?');
+                'Are you sure you want to leave the room "lounge"?');
             room_els = _converse.rooms_list_view.el.querySelectorAll(".open-room");
             expect(room_els.length).toBe(0);
             expect(_converse.chatboxes.length).toBe(1);

+ 6 - 2
src/templates/rooms_list_item.html

@@ -2,9 +2,13 @@
 {[ if (num_unread) { ]}
     <span class="msgs-indicator">{{{ num_unread }}}</span>
 {[ } ]}
-<a class="open-room" data-room-jid="{{{jid}}}" title="{{{open_title}}}" href="#">{{{name}}}</a>
+<a class="open-room"
+    data-room-jid="{{{jid}}}"
+    title="{{{open_title}}}" href="#">{{{name}}}</a>
 <a class="right close-room icon-leave"
-   data-room-jid="{{{jid}}}" title="{{{info_leave_room}}}" href="#">&nbsp;</a>
+   data-room-jid="{{{jid}}}"
+   data-room-name="{{{name}}}"
+   title="{{{info_leave_room}}}" href="#">&nbsp;</a>
 <a class="right remove-bookmark icon-pushpin {[ if (bookmarked) { ]} button-on {[ } ]}"
    data-room-jid="{{{jid}}}" data-bookmark-name="{{{name}}}"
    title="{{{info_remove_bookmark}}}" href="#">&nbsp;</a>