Browse Source

Avoid `RID out of range` errors in Prosody

by not flushing stanzas when sending out an <inactive> CSI.

When reloading the page, the stanzas are resent (because we never had
time to receive acks) which causes problems on Prosody (and likely also
causes the Ejabberd "other-request" errors).
JC Brand 6 years ago
parent
commit
dd3133e7de
3 changed files with 2 additions and 3 deletions
  1. 1 0
      CHANGES.md
  2. 1 2
      dist/converse.js
  3. 0 1
      src/converse-chatview.js

+ 1 - 0
CHANGES.md

@@ -3,6 +3,7 @@
 ## 4.0.6 (unreleased)
 
 - Don't render http (i.e. non-TLS) resources
+- Bugfix: Converse caused `RID out of range` errors on Prosody
 - #1331 Fix missing checkmarks in old muc messages
 - #1333 Don't send receipt requests in MUCs
 

+ 1 - 2
dist/converse.js

@@ -42758,6 +42758,7 @@ Strophe.Websocket.prototype = {
 });
 //# sourceMappingURL=strophe.js.map
 
+
 /***/ }),
 
 /***/ "./node_modules/strophejs-plugin-ping/strophe.ping.js":
@@ -50737,8 +50738,6 @@ _converse_headless_converse_core__WEBPACK_IMPORTED_MODULE_5__["default"].plugins
             'silent': true
           });
           this.model.sendChatState();
-
-          _converse.connection.flush();
         }
       }
 

+ 0 - 1
src/converse-chatview.js

@@ -1290,7 +1290,6 @@ converse.plugins.add('converse-chatview', {
                 } else if (state === 'hidden') {
                     this.setChatState(_converse.INACTIVE, {'silent': true});
                     this.model.sendChatState();
-                    _converse.connection.flush();
                 }
             }
         });