Quellcode durchsuchen

Release 10.1.5

Refine the `dist` step by creating a proper temporary file.

I spent a lot of time trying to pinpoint the underlying cause, why
translation chunk files are empty when generating a bundle with newer JS
features (i.e. not pinning preset-env to IE11) but couldn't find it.
JC Brand vor 2 Jahren
Ursprung
Commit
e31d4c7bac
1 geänderte Dateien mit 9 neuen und 9 gelöschten Zeilen
  1. 9 9
      Makefile

+ 9 - 9
Makefile

@@ -205,16 +205,16 @@ src/headless/dist/converse-headless.min.js: src webpack/webpack.common.js node_m
 
 dist:: node_modules src/* | dist/website.css dist/website.min.css
 	npm run headless
-	# Ideally this should just be `npm run nodeps`.
-	# The additional steps are necessary to properly generate JSON files from
-	# the .po files. The nodeps config uses preset-env with IE11 to turn all
-	# template literals into old JS strings, which is required because
-	# gettext 0.21 doesn't support template literals.
+	# Ideally this should just be `npm run build`.
+	# The additional steps are necessary to properly generate JSON chunk files
+	# from the .po files. The nodeps config uses preset-env with IE11.
+	# Somehow this is necessary.
 	npm run nodeps
-	mkdir tmp && mv dist/locales tmp
-	npm run build
-	cp tmp/locales/*-po.js dist/locales/
-	rm -rf tmp
+	$(eval TMPD := $(shell mktemp -d))
+	mv dist/locales $(TMPD) && \
+	npm run build && \
+	mv $(TMPD)/locales/*-po.js dist/locales/ && \
+	rm -rf $(TMPD)
 
 .PHONY: install
 install:: dist