converse.js/spec/roster.js

(function (root, factory) {
    define(["jasmine", "mock", "test-utils"], factory);
} (this, function (jasmine, mock, test_utils) {
    const $iq = converse.env.$iq;
    const $pres = converse.env.$pres;
    const Strophe = converse.env.Strophe;
    const _ = converse.env._;
    const sizzle = converse.env.sizzle;
    const u = converse.env.utils;

    const checkHeaderToggling = async function (group) {
        const toggle = group.querySelector('a.group-toggle');
        expect(u.isVisible(group)).toBeTruthy();
        expect(group.querySelectorAll('ul.collapsed').length).toBe(0);
        expect(u.hasClass('fa-caret-right', toggle.firstElementChild)).toBeFalsy();
        expect(u.hasClass('fa-caret-down', toggle.firstElementChild)).toBeTruthy();
        toggle.click();

        await u.waitUntil(() => group.querySelectorAll('ul.collapsed').length === 1);
        expect(u.hasClass('fa-caret-right', toggle.firstElementChild)).toBeTruthy();
        expect(u.hasClass('fa-caret-down', toggle.firstElementChild)).toBeFalsy();
        toggle.click();
        await u.waitUntil(() => group.querySelectorAll('li').length === _.filter(group.querySelectorAll('li'), u.isVisible).length);
        expect(u.hasClass('fa-caret-right', toggle.firstElementChild)).toBeFalsy();
        expect(u.hasClass('fa-caret-down', toggle.firstElementChild)).toBeTruthy();
    };


    describe("The Contacts Roster", function () {

        it("verifies the origin of roster pushes",
            mock.initConverse(
                ['rosterGroupsFetched', 'chatBoxesFetched'], {},
                async function (done, _converse) {

            // See: https://gultsch.de/gajim_roster_push_and_message_interception.html
            const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
            await test_utils.waitForRoster(_converse, 'current', 1);
            expect(_converse.roster.models.length).toBe(1);
            expect(_converse.roster.at(0).get('jid')).toBe(contact_jid);

            spyOn(converse.env.log, 'warn');
            let roster_push = u.toStanza(`
                <iq type="set" to="${_converse.jid}" from="eve@siacs.eu">
                    <query xmlns='jabber:iq:roster'>
                        <item subscription="remove" jid="${contact_jid}"/>
                    </query>
                </iq>`);
            _converse.connection._dataRecv(test_utils.createRequest(roster_push));
            expect(converse.env.log.warn.calls.count()).toBe(1);
            expect(converse.env.log.warn).toHaveBeenCalledWith(
                `Ignoring roster illegitimate roster push message from ${roster_push.getAttribute('from')}`
            );
            roster_push = u.toStanza(`
                <iq type="set" to="${_converse.jid}" from="eve@siacs.eu">
                    <query xmlns='jabber:iq:roster'>
                        <item subscription="both" jid="eve@siacs.eu" name="${mock.cur_names[0]}" />
                    </query>
                </iq>`);
            _converse.connection._dataRecv(test_utils.createRequest(roster_push));
            expect(converse.env.log.warn.calls.count()).toBe(2);
            expect(converse.env.log.warn).toHaveBeenCalledWith(
                `Ignoring roster illegitimate roster push message from ${roster_push.getAttribute('from')}`
            );
            expect(_converse.roster.models.length).toBe(1);
            expect(_converse.roster.at(0).get('jid')).toBe(contact_jid);
            done();
        }));

        it("is populated once we have registered a presence handler",
            mock.initConverse(
                ['rosterGroupsFetched'], {},
                async function (done, _converse) {

            const IQs = _converse.connection.IQ_stanzas;
            const stanza = await u.waitUntil(
                () => _.filter(IQs, iq => iq.querySelector('iq query[xmlns="jabber:iq:roster"]')).pop());

            expect(Strophe.serialize(stanza)).toBe(
                `<iq id="${stanza.getAttribute('id')}" type="get" xmlns="jabber:client">`+
                    `<query xmlns="jabber:iq:roster"/>`+
                `</iq>`);
            const result = $iq({
                'to': _converse.connection.jid,
                'type': 'result',
                'id': stanza.getAttribute('id')
            }).c('query', {
                'xmlns': 'jabber:iq:roster'
            }).c('item', {'jid': 'nurse@example.com'}).up()
              .c('item', {'jid': 'romeo@example.com'})
            _converse.connection._dataRecv(test_utils.createRequest(result));
            await u.waitUntil(() => _converse.promises['rosterContactsFetched'].isResolved === true);
            done();
        }));

        it("supports roster versioning",
            mock.initConverse(
                ['rosterGroupsFetched'], {},
                async function (done, _converse) {

            const IQ_stanzas = _converse.connection.IQ_stanzas;
            let stanza = await u.waitUntil(
                () => _.filter(IQ_stanzas, iq => iq.querySelector('iq query[xmlns="jabber:iq:roster"]')).pop()
            );
            expect(_converse.roster.data.get('version')).toBeUndefined();
            expect(Strophe.serialize(stanza)).toBe(
                `<iq id="${stanza.getAttribute('id')}" type="get" xmlns="jabber:client">`+
                    `<query xmlns="jabber:iq:roster"/>`+
                `</iq>`);
            let result = $iq({
                'to': _converse.connection.jid,
                'type': 'result',
                'id': stanza.getAttribute('id')
            }).c('query', {
                'xmlns': 'jabber:iq:roster',
                'ver': 'ver7'
            }).c('item', {'jid': 'nurse@example.com'}).up()
              .c('item', {'jid': 'romeo@example.com'})
            _converse.connection._dataRecv(test_utils.createRequest(result));

            await u.waitUntil(() => _converse.roster.models.length > 1);
            expect(_converse.roster.data.get('version')).toBe('ver7');
            expect(_converse.roster.models.length).toBe(2);

            _converse.roster.fetchFromServer();
            stanza = _converse.connection.IQ_stanzas.pop();
            expect(Strophe.serialize(stanza)).toBe(
                `<iq id="${stanza.getAttribute('id')}" type="get" xmlns="jabber:client">`+
                    `<query ver="ver7" xmlns="jabber:iq:roster"/>`+
                `</iq>`);

            result = $iq({
                'to': _converse.connection.jid,
                'type': 'result',
                'id': stanza.getAttribute('id')
            });
            _converse.connection._dataRecv(test_utils.createRequest(result));

            const roster_push = $iq({
                'to': _converse.connection.jid,
                'type': 'set',
            }).c('query', {'xmlns': 'jabber:iq:roster', 'ver': 'ver34'})
                .c('item', {'jid': 'romeo@example.com', 'subscription': 'remove'});
            _converse.connection._dataRecv(test_utils.createRequest(roster_push));
            expect(_converse.roster.data.get('version')).toBe('ver34');
            expect(_converse.roster.models.length).toBe(1);
            expect(_converse.roster.at(0).get('jid')).toBe('nurse@example.com');
            done();
        }));

        describe("The live filter", function () {

            it("will only appear when roster contacts flow over the visible area",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                const filter = _converse.rosterview.el.querySelector('.roster-filter');
                expect(filter === null).toBe(false);
                await test_utils.waitForRoster(_converse, 'current');
                await test_utils.openControlBox(_converse);

                const view = _converse.chatboxviews.get('controlbox');
                const flyout = view.el.querySelector('.box-flyout');
                const panel = flyout.querySelector('.controlbox-pane');
                function hasScrollBar (el) {
                    return el.isConnected && flyout.offsetHeight < panel.scrollHeight;
                }
                const el = _converse.rosterview.roster_el;
                await u.waitUntil(() => hasScrollBar(el) ? u.isVisible(filter) : !u.isVisible(filter), 900);
                done();
            }));

            it("can be used to filter the contacts shown",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'roster_groups': true},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current');
                let filter = _converse.rosterview.el.querySelector('.roster-filter');
                const roster = _converse.rosterview.roster_el;
                _converse.rosterview.filter_view.delegateEvents();

                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 17), 600);
                expect(sizzle('ul.roster-group-contacts', roster).filter(u.isVisible).length).toBe(5);
                filter.value = "juliet";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 1), 600);
                // Only one roster contact is now visible
                let visible_contacts = sizzle('li', roster).filter(u.isVisible);
                expect(visible_contacts.length).toBe(1);
                expect(visible_contacts.pop().textContent.trim()).toBe('Juliet Capulet');
                // Only one foster group is still visible
                expect(sizzle('.roster-group', roster).filter(u.isVisible).length).toBe(1);
                const visible_group = sizzle('.roster-group', roster).filter(u.isVisible).pop();
                expect(visible_group.querySelector('a.group-toggle').textContent.trim()).toBe('friends & acquaintences');

                filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = "j";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 2), 700);

                visible_contacts = sizzle('li', roster).filter(u.isVisible);
                expect(visible_contacts.length).toBe(2);

                let visible_groups = sizzle('.roster-group', roster).filter(u.isVisible).map(el => el.querySelector('a.group-toggle'));
                expect(visible_groups.length).toBe(2);
                expect(visible_groups[0].textContent.trim()).toBe('friends & acquaintences');
                expect(visible_groups[1].textContent.trim()).toBe('Ungrouped');

                filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = "xxx";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 0), 600);
                visible_groups = sizzle('.roster-group', roster).filter(u.isVisible).map(el => el.querySelector('a.group-toggle'));
                expect(visible_groups.length).toBe(0);

                filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = "";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 17), 600);
                expect(sizzle('ul.roster-group-contacts', roster).filter(u.isVisible).length).toBe(5);
                done();
            }));

            it("will also filter out contacts added afterwards",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current');

                const filter = _converse.rosterview.el.querySelector('.roster-filter');
                const roster = _converse.rosterview.roster_el;
                _converse.rosterview.filter_view.delegateEvents();

                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 17), 800);
                filter.value = "la";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 4), 800);

                // Five roster contact is now visible
                const visible_contacts = sizzle('li', roster).filter(u.isVisible);
                expect(visible_contacts.length).toBe(4);
                let visible_groups = sizzle('.roster-group', roster).filter(u.isVisible).map(el => el.querySelector('a.group-toggle'));
                expect(visible_groups.length).toBe(4);
                expect(visible_groups[0].textContent.trim()).toBe('Colleagues');
                expect(visible_groups[1].textContent.trim()).toBe('Family');
                expect(visible_groups[2].textContent.trim()).toBe('friends & acquaintences');
                expect(visible_groups[3].textContent.trim()).toBe('ænemies');

                _converse.roster.create({
                    jid: 'valentine@montague.lit',
                    subscription: 'both',
                    ask: null,
                    groups: ['newgroup'],
                    fullname: 'Valentine'
                });
                await u.waitUntil(() => sizzle('.roster-group[data-group="newgroup"] li', roster).length, 300);
                visible_groups = sizzle('.roster-group', roster).filter(u.isVisible).map(el => el.querySelector('a.group-toggle'));
                // The "newgroup" group doesn't appear
                expect(visible_groups.length).toBe(4);
                expect(visible_groups[0].textContent.trim()).toBe('Colleagues');
                expect(visible_groups[1].textContent.trim()).toBe('Family');
                expect(visible_groups[2].textContent.trim()).toBe('friends & acquaintences');
                expect(visible_groups[3].textContent.trim()).toBe('ænemies');
                expect(roster.querySelectorAll('.roster-group').length).toBe(6);
                done();
            }));

            it("can be used to filter the groups shown",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'roster_groups': true},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current');
                _converse.rosterview.filter_view.delegateEvents();
                var roster = _converse.rosterview.roster_el;

                var button = _converse.rosterview.el.querySelector('span[data-type="groups"]');
                button.click();

                await u.waitUntil(() => (sizzle('li', roster).filter(u.isVisible).length === 17), 600);
                expect(sizzle('.roster-group', roster).filter(u.isVisible).length).toBe(5);

                var filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = "colleagues";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");

                await u.waitUntil(() => (sizzle('div.roster-group:not(.collapsed)', roster).length === 1), 600);
                expect(sizzle('div.roster-group:not(.collapsed)', roster).pop().firstElementChild.textContent.trim()).toBe('Colleagues');
                expect(sizzle('div.roster-group:not(.collapsed) li', roster).filter(u.isVisible).length).toBe(6);
                // Check that all contacts under the group are shown
                expect(sizzle('div.roster-group:not(.collapsed) li', roster).filter(l => !u.isVisible(l)).length).toBe(0);

                filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = "xxx";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");

                await u.waitUntil(() => (roster.querySelectorAll('div.roster-group.collapsed').length === 5), 700);
                expect(roster.querySelectorAll('div.roster-group:not(.collapsed) a').length).toBe(0);

                filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = ""; // Check that groups are shown again, when the filter string is cleared.
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                await u.waitUntil(() => (roster.querySelectorAll('div.roster-group.collapsed').length === 0), 700);
                expect(sizzle('div.roster-group:not(collapsed)', roster).length).toBe(5);
                expect(sizzle('div.roster-group:not(collapsed) li', roster).length).toBe(17);
                done();
            }));

            it("has a button with which its contents can be cleared",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'roster_groups': true},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current');

                const filter = _converse.rosterview.el.querySelector('.roster-filter');
                filter.value = "xxx";
                u.triggerEvent(filter, "keydown", "KeyboardEvent");
                expect(_.includes(filter.classList, "x")).toBeFalsy();
                expect(u.hasClass('hidden', _converse.rosterview.el.querySelector('.roster-filter-form .clear-input'))).toBeTruthy();

                const isHidden = _.partial(u.hasClass, 'hidden');
                await u.waitUntil(() => !isHidden(_converse.rosterview.el.querySelector('.roster-filter-form .clear-input')), 900);
                _converse.rosterview.el.querySelector('.clear-input').click();
                expect(document.querySelector('.roster-filter').value).toBe("");
                done();
            }));

            // Disabling for now, because since recently this test consistently
            // fails on Travis and I couldn't get it to pass there.
            xit("can be used to filter contacts by their chat state",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                test_utils.waitForRoster(_converse, 'all');
                let jid = mock.cur_names[3].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                _converse.roster.get(jid).presence.set('show', 'online');
                jid = mock.cur_names[4].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                _converse.roster.get(jid).presence.set('show', 'dnd');
                test_utils.openControlBox(_converse);
                const button = _converse.rosterview.el.querySelector('span[data-type="state"]');
                button.click();
                const roster = _converse.rosterview.roster_el;
                await u.waitUntil(() => sizzle('li', roster).filter(u.isVisible).length === 15, 900);
                const filter = _converse.rosterview.el.querySelector('.state-type');
                expect(sizzle('ul.roster-group-contacts', roster).filter(u.isVisible).length).toBe(5);
                filter.value = "online";
                u.triggerEvent(filter, 'change');

                await u.waitUntil(() => sizzle('li', roster).filter(u.isVisible).length === 1, 900);
                expect(sizzle('li', roster).filter(u.isVisible).pop().textContent.trim()).toBe('Lord Montague');
                await u.waitUntil(() => sizzle('ul.roster-group-contacts', roster).filter(u.isVisible).length === 1, 900);
                const ul = sizzle('ul.roster-group-contacts', roster).filter(u.isVisible).pop();
                expect(ul.parentElement.firstElementChild.textContent.trim()).toBe('friends & acquaintences');
                filter.value = "dnd";
                u.triggerEvent(filter, 'change');
                await u.waitUntil(() => sizzle('li', roster).filter(u.isVisible).pop().textContent.trim() === 'Friar Laurence', 900);
                expect(sizzle('ul.roster-group-contacts', roster).filter(u.isVisible).length).toBe(1);
                done();
            }));
        });

        describe("A Roster Group", function () {

            it("can be used to organize existing contacts",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'roster_groups': true},
                    async function (done, _converse) {

                spyOn(_converse.rosterview, 'update').and.callThrough();
                _converse.rosterview.render();
                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'all');
                await test_utils.createContacts(_converse, 'requesting');
                // Check that the groups appear alphabetically and that
                // requesting and pending contacts are last.
                await u.waitUntil(() => sizzle('.roster-group a.group-toggle', _converse.rosterview.el).length);
                const group_titles = sizzle('.roster-group a.group-toggle', _converse.rosterview.el).map(o => o.textContent.trim());
                expect(group_titles).toEqual([
                    "Contact requests",
                    "Colleagues",
                    "Family",
                    "friends & acquaintences",
                    "ænemies",
                    "Ungrouped",
                    "Pending contacts"
                ]);
                // Check that usernames appear alphabetically per group
                Object.keys(mock.groups).forEach(name  => {
                    const contacts = sizzle('.roster-group[data-group="'+name+'"] ul', _converse.rosterview.el);
                    const names = _.map(contacts, o => o.textContent.trim());
                    expect(names).toEqual(_.clone(names).sort());
                });
                done();
            }));

            it("gets created when a contact's \"groups\" attribute changes",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'roster_groups': true},
                    async function (done, _converse) {

                spyOn(_converse.rosterview, 'update').and.callThrough();
                _converse.rosterview.render();

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current', 0);

                _converse.roster.create({
                    jid: 'groupchanger@montague.lit',
                    subscription: 'both',
                    ask: null,
                    groups: ['firstgroup'],
                    fullname: 'George Groupchanger'
                });

                // Check that the groups appear alphabetically and that
                // requesting and pending contacts are last.
                let group_titles = await u.waitUntil(() => {
                    const toggles = sizzle('.roster-group a.group-toggle', _converse.rosterview.el);
                    if (_.reduce(toggles, (result, t) => result && u.isVisible(t), true)) {
                        return _.map(toggles, o => o.textContent.trim());
                    } else {
                        return false;
                    }
                }, 1000);
                expect(group_titles).toEqual(['firstgroup']);

                const contact = _converse.roster.get('groupchanger@montague.lit');
                contact.set({'groups': ['secondgroup']});
                group_titles = await u.waitUntil(() => {
                    const toggles = sizzle('.roster-group[data-group="secondgroup"] a.group-toggle', _converse.rosterview.el);
                    if (_.reduce(toggles, (result, t) => result && u.isVisible(t), true)) {
                        return _.map(toggles, o => o.textContent.trim());
                    } else {
                        return false;
                    }
                }, 1000);
                expect(group_titles).toEqual(['secondgroup']);
                done();
            }));

            it("can share contacts with other roster groups",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'roster_groups': true},
                    async function (done, _converse) {

                const groups = ['Colleagues', 'friends'];
                spyOn(_converse.rosterview, 'update').and.callThrough();
                test_utils.openControlBox(_converse);
                _converse.rosterview.render();
                for (var i=0; i<mock.cur_names.length; i++) {
                    _converse.roster.create({
                        jid: mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit',
                        subscription: 'both',
                        ask: null,
                        groups: groups,
                        fullname: mock.cur_names[i]
                    });
                }
                await u.waitUntil(() => (sizzle('li', _converse.rosterview.el).filter(u.isVisible).length === 30), 600);
                // Check that usernames appear alphabetically per group
                _.each(groups, function (name) {
                    const contacts = sizzle('.roster-group[data-group="'+name+'"] ul li', _converse.rosterview.el);
                    const names = contacts.map(o => o.textContent.trim());
                    expect(names).toEqual(_.clone(names).sort());
                    expect(names.length).toEqual(mock.cur_names.length);
                });
                done();
            }));

            it("remembers whether it is closed or opened",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                _converse.roster_groups = true;
                test_utils.openControlBox(_converse);

                var i=0, j=0;
                var groups = {
                    'Colleagues': 3,
                    'friends & acquaintences': 3,
                    'Ungrouped': 2
                };
                _.each(_.keys(groups), function (name) {
                    j = i;
                    for (i=j; i<j+groups[name]; i++) {
                        _converse.roster.create({
                            jid: mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit',
                            subscription: 'both',
                            ask: null,
                            groups: name === 'ungrouped'? [] : [name],
                            fullname: mock.cur_names[i]
                        });
                    }
                });
                const view = _converse.rosterview.get('Colleagues');
                const toggle = view.el.querySelector('a.group-toggle');
                expect(view.model.get('state')).toBe('opened');
                toggle.click();
                await u.waitUntil(() => view.model.get('state') === 'closed');
                toggle.click();
                await u.waitUntil(() => view.model.get('state') === 'opened');
                done();
            }));
        });

        describe("Pending Contacts", function () {

            it("can be collapsed under their own header",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'all');
                await Promise.all(_converse.roster.forEach(contact => u.waitUntil(() => contact.vcard.get('fullname'))));
                await u.waitUntil(() => sizzle('.roster-group', _converse.rosterview.el).filter(u.isVisible).map(e => e.querySelector('li')).length, 1000);
                await checkHeaderToggling.apply(
                    _converse,
                    [_converse.rosterview.get('Pending contacts').el]
                );
                done();
            }));

            it("can be added to the roster",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                spyOn(_converse.rosterview, 'update').and.callThrough();
                await test_utils.openControlBox(_converse);
                _converse.roster.create({
                    jid: mock.pend_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit',
                    subscription: 'none',
                    ask: 'subscribe',
                    fullname: mock.pend_names[0]
                });
                expect(_converse.rosterview.update).toHaveBeenCalled();
                done();
            }));

            it("are shown in the roster when hide_offline_users",
                mock.initConverse(
                    ['rosterGroupsFetched'], {'hide_offline_users': true},
                    async function (done, _converse) {

                spyOn(_converse.rosterview, 'update').and.callThrough();
                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'pending');
                await Promise.all(_converse.roster.forEach(contact => u.waitUntil(() => contact.vcard.get('fullname'))));
                await u.waitUntil(() => sizzle('li', _converse.rosterview.el).filter(u.isVisible).length, 500)
                expect(_converse.rosterview.update).toHaveBeenCalled();
                expect(u.isVisible(_converse.rosterview.el)).toBe(true);
                expect(sizzle('li', _converse.rosterview.el).filter(u.isVisible).length).toBe(3);
                expect(sizzle('ul.roster-group-contacts', _converse.rosterview.el).filter(u.isVisible).length).toBe(1);
                done();
            }));

            it("can be removed by the user",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.waitForRoster(_converse, 'all');
                await Promise.all(_converse.roster.forEach(contact => u.waitUntil(() => contact.vcard.get('fullname'))));
                const name = mock.pend_names[0];
                const jid = name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                const contact = _converse.roster.get(jid);
                var sent_IQ;
                spyOn(window, 'confirm').and.returnValue(true);
                spyOn(contact, 'unauthorize').and.callFake(function () { return contact; });
                spyOn(contact, 'removeFromRoster').and.callThrough();
                await u.waitUntil(() => sizzle(".pending-contact-name:contains('"+name+"')", _converse.rosterview.el).length, 700);
                spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
                    sent_IQ = iq;
                    callback();
                });
                sizzle(`.remove-xmpp-contact[title="Click to remove ${name} as a contact"]`, _converse.rosterview.el).pop().click();
                await u.waitUntil(() => (sizzle(".pending-contact-name:contains('"+name+"')", _converse.rosterview.el).length === 0), 1000);
                expect(window.confirm).toHaveBeenCalled();
                expect(contact.removeFromRoster).toHaveBeenCalled();
                expect(sent_IQ.toLocaleString()).toBe(
                    `<iq type="set" xmlns="jabber:client">`+
                        `<query xmlns="jabber:iq:roster">`+
                            `<item jid="lord.capulet@montague.lit" subscription="remove"/>`+
                        `</query>`+
                    `</iq>`);
                done();
            }));

            it("do not have a header if there aren't any",
                mock.initConverse(
                    ['rosterGroupsFetched', 'VCardsInitialized'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current', 0);
                const name = mock.pend_names[0];
                _converse.roster.create({
                    jid: name.replace(/ /g,'.').toLowerCase() + '@montague.lit',
                    subscription: 'none',
                    ask: 'subscribe',
                    fullname: name
                });
                await u.waitUntil(() => {
                    const el = _converse.rosterview.get('Pending contacts').el;
                    return u.isVisible(el) && _.filter(el.querySelectorAll('li'), li => u.isVisible(li)).length;
                }, 700)

                const remove_el = await u.waitUntil(() => sizzle(`.remove-xmpp-contact[title="Click to remove ${name} as a contact"]`, _converse.rosterview.el).pop());
                spyOn(window, 'confirm').and.returnValue(true);
                remove_el.click();
                expect(window.confirm).toHaveBeenCalled();

                const iq = _converse.connection.IQ_stanzas.pop();
                expect(Strophe.serialize(iq)).toBe(
                    `<iq id="${iq.getAttribute('id')}" type="set" xmlns="jabber:client">`+
                        `<query xmlns="jabber:iq:roster">`+
                            `<item jid="lord.capulet@montague.lit" subscription="remove"/>`+
                        `</query>`+
                    `</iq>`);

                const stanza = u.toStanza(`<iq id="${iq.getAttribute('id')}" to="romeo@montague.lit/orchard" type="result"/>`);
                _converse.connection._dataRecv(test_utils.createRequest(stanza));
                await u.waitUntil(() => !u.isVisible(_converse.rosterview.get('Pending contacts').el));
                done();
            }));

            it("is shown when a new private message is received",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.waitForRoster(_converse, 'all');
                await Promise.all(_converse.roster.forEach(contact => u.waitUntil(() => contact.vcard.get('fullname'))));
                await u.waitUntil(() => _converse.roster.at(0).vcard.get('fullname'))
                spyOn(window, 'confirm').and.returnValue(true);
                for (var i=0; i<mock.pend_names.length; i++) {
                    const name = mock.pend_names[i];
                    sizzle(`.remove-xmpp-contact[title="Click to remove ${name} as a contact"]`, _converse.rosterview.el).pop().click();
                }
                expect(u.isVisible(_converse.rosterview.get('Pending contacts').el)).toBe(false);
                done();
            }));

            it("can be added to the roster and they will be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current');
                await Promise.all(_converse.roster.forEach(contact => u.waitUntil(() => contact.vcard.get('fullname'))));
                spyOn(_converse.rosterview, 'update').and.callThrough();
                let i;
                for (i=0; i<mock.pend_names.length; i++) {
                    _converse.roster.create({
                        jid: mock.pend_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit',
                        subscription: 'none',
                        ask: 'subscribe',
                        fullname: mock.pend_names[i]
                    });
                    expect(_converse.rosterview.update).toHaveBeenCalled();
                }
                await u.waitUntil(() => sizzle('li', _converse.rosterview.get('Pending contacts').el).filter(u.isVisible).length, 900);
                // Check that they are sorted alphabetically
                const view = _converse.rosterview.get('Pending contacts');
                const spans = view.el.querySelectorAll('.pending-xmpp-contact span');
                const t = _.reduce(spans, (result, value) => result + _.trim(value.textContent), '');
                expect(t).toEqual(mock.pend_names.slice(0,i+1).sort().join(''));
                done();
            }));
        });

        describe("Existing Contacts", function () {
            async function _addContacts (_converse) {
                await test_utils.waitForRoster(_converse, 'current');
                await test_utils.openControlBox(_converse);
                await Promise.all(_converse.roster.forEach(contact => u.waitUntil(() => contact.vcard.get('fullname'))));
            }

            it("can be collapsed under their own header",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('li', _converse.rosterview.el).filter(u.isVisible).length, 500);
                await checkHeaderToggling.apply(_converse, [_converse.rosterview.el.querySelector('.roster-group')]);
                done();
            }));

            it("will be hidden when appearing under a collapsed group",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                _converse.roster_groups = false;
                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('li', _converse.rosterview.el).filter(u.isVisible).length, 500);
                _converse.rosterview.el.querySelector('.roster-group a.group-toggle').click();
                const name = "Romeo Montague";
                const jid = name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                _converse.roster.create({
                    ask: null,
                    fullname: name,
                    jid: jid,
                    requesting: false,
                    subscription: 'both'
                });
                const view = _converse.rosterview.get('My contacts').get(jid);
                expect(u.isVisible(view.el)).toBe(false);
                done();
            }));

            it("can be added to the roster and they will be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                spyOn(_converse.rosterview, 'update').and.callThrough();
                await Promise.all(mock.cur_names.map(name => {
                    const contact = _converse.roster.create({
                        jid: name.replace(/ /g,'.').toLowerCase() + '@montague.lit',
                        subscription: 'both',
                        ask: null,
                        fullname: name
                    });
                    return u.waitUntil(() => contact.initialized);
                }));
                await u.waitUntil(() => sizzle('li', _converse.rosterview.el).length, 600);
                // Check that they are sorted alphabetically
                const els = sizzle('.roster-group .current-xmpp-contact.offline a.open-chat', _converse.rosterview.el)
                const t = els.reduce((result, value) => (result + value.textContent.trim()), '');
                expect(t).toEqual(mock.cur_names.slice(0,mock.cur_names.length).sort().join(''));
                done();
            }));

            it("can be removed by the user",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => _converse.rosterview.el.querySelectorAll('li').length);
                const name = mock.cur_names[0];
                const jid = name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                const contact = _converse.roster.get(jid);
                spyOn(window, 'confirm').and.returnValue(true);
                spyOn(contact, 'removeFromRoster').and.callThrough();

                let sent_IQ;
                spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
                    sent_IQ = iq;
                    callback();
                });
                sizzle(`.remove-xmpp-contact[title="Click to remove ${name} as a contact"]`, _converse.rosterview.el).pop().click();
                expect(window.confirm).toHaveBeenCalled();
                expect(sent_IQ.toLocaleString()).toBe(
                    `<iq type="set" xmlns="jabber:client">`+
                        `<query xmlns="jabber:iq:roster"><item jid="mercutio@montague.lit" subscription="remove"/></query>`+
                    `</iq>`);
                expect(contact.removeFromRoster).toHaveBeenCalled();
                await u.waitUntil(() => sizzle(".open-chat:contains('"+name+"')", _converse.rosterview.el).length === 0);
                done();
            }));

            it("do not have a header if there aren't any",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current', 0);
                const name = mock.cur_names[0];
                const contact = _converse.roster.create({
                    jid: name.replace(/ /g,'.').toLowerCase() + '@montague.lit',
                    subscription: 'both',
                    ask: null,
                    fullname: name
                });
                await u.waitUntil(() => sizzle('.roster-group', _converse.rosterview.el).filter(u.isVisible).map(e => e.querySelector('li')).length, 1000);
                spyOn(window, 'confirm').and.returnValue(true);
                spyOn(contact, 'removeFromRoster').and.callThrough();
                spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback) {
                    if (typeof callback === "function") { return callback(); }
                });
                expect(u.isVisible(_converse.rosterview.el.querySelector('.roster-group'))).toBe(true);
                sizzle(`.remove-xmpp-contact[title="Click to remove ${name} as a contact"]`, _converse.rosterview.el).pop().click();
                expect(window.confirm).toHaveBeenCalled();
                expect(_converse.connection.sendIQ).toHaveBeenCalled();
                expect(contact.removeFromRoster).toHaveBeenCalled();
                await u.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length === 0);
                done();
            }));

            it("can change their status to online and be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group li').length, 700);
                const roster = _converse.rosterview.el;
                const groups = roster.querySelectorAll('.roster-group');
                const groupnames = Array.from(groups).map(g => g.getAttribute('data-group'));
                expect(groupnames.join(' ')).toBe("Colleagues Family friends & acquaintences ænemies Ungrouped");
                for (let i=0; i<mock.cur_names.length; i++) {
                    const jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'online');
                    // Check that they are sorted alphabetically
                    for (let j=0; j<groups.length; j++) {
                        const group = groups[j];
                        const groupname = groupnames[j];
                        const els = group.querySelectorAll('.current-xmpp-contact.online a.open-chat');
                        const t = _.reduce(els, (result, value) => result + _.trim(value.textContent), '');
                        expect(t).toEqual(mock.groups_map[groupname].slice(0, els.length).sort().join(''));
                    }
                }
                done();
            }));

            it("can change their status to busy and be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 700);
                const roster = _converse.rosterview.el;
                const groups = roster.querySelectorAll('.roster-group');
                const groupnames = Array.from(groups).map(g => g.getAttribute('data-group'));
                expect(groupnames.join(' ')).toBe("Colleagues Family friends & acquaintences ænemies Ungrouped");
                for (let i=0; i<mock.cur_names.length; i++) {
                    const jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'dnd');
                    // Check that they are sorted alphabetically
                    for (let j=0; j<groups.length; j++) {
                        const group = groups[j];
                        const groupname = groupnames[j];
                        const els = group.querySelectorAll('.current-xmpp-contact.dnd a.open-chat');
                        const t = _.reduce(els, (result, value) => result + _.trim(value.textContent), '');
                        expect(t).toEqual(mock.groups_map[groupname].slice(0, els.length).sort().join(''));
                    }
                }
                done();
            }));

            it("can change their status to away and be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 700);
                const roster = _converse.rosterview.el;
                const groups = roster.querySelectorAll('.roster-group');
                const groupnames = Array.from(groups).map(g => g.getAttribute('data-group'));
                expect(groupnames.join(' ')).toBe("Colleagues Family friends & acquaintences ænemies Ungrouped");
                for (let i=0; i<mock.cur_names.length; i++) {
                    const jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'away');
                    // Check that they are sorted alphabetically
                    for (let j=0; j<groups.length; j++) {
                        const group = groups[j];
                        const groupname = groupnames[j];
                        const els = group.querySelectorAll('.current-xmpp-contact.away a.open-chat');
                        const t = _.reduce(els, (result, value) => result + _.trim(value.textContent), '');
                        expect(t).toEqual(mock.groups_map[groupname].slice(0, els.length).sort().join(''));
                    }
                }
                done();
            }));

            it("can change their status to xa and be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 700);
                const roster = _converse.rosterview.el;
                const groups = roster.querySelectorAll('.roster-group');
                const groupnames = Array.from(groups).map(g => g.getAttribute('data-group'));
                expect(groupnames.join(' ')).toBe("Colleagues Family friends & acquaintences ænemies Ungrouped");
                for (let i=0; i<mock.cur_names.length; i++) {
                    const jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'xa');
                    // Check that they are sorted alphabetically
                    for (let j=0; j<groups.length; j++) {
                        const group = groups[j];
                        const groupname = groupnames[j];
                        const els = group.querySelectorAll('.current-xmpp-contact.xa a.open-chat');
                        const t = _.reduce(els, (result, value) => result + _.trim(value.textContent), '');
                        expect(t).toEqual(mock.groups_map[groupname].slice(0, els.length).sort().join(''));
                    }
                }
                done();
            }));

            it("can change their status to unavailable and be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 500)
                const roster = _converse.rosterview.el;
                const groups = roster.querySelectorAll('.roster-group');
                const groupnames = Array.from(groups).map(g => g.getAttribute('data-group'));
                expect(groupnames.join(' ')).toBe("Colleagues Family friends & acquaintences ænemies Ungrouped");
                for (let i=0; i<mock.cur_names.length; i++) {
                    const jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'unavailable');
                    // Check that they are sorted alphabetically
                    for (let j=0; j<groups.length; j++) {
                        const group = groups[j];
                        const groupname = groupnames[j];
                        const els = group.querySelectorAll('.current-xmpp-contact.unavailable a.open-chat');
                        const t = _.reduce(els, (result, value) => result + _.trim(value.textContent), '');
                        expect(t).toEqual(mock.groups_map[groupname].slice(0, els.length).sort().join(''));
                    }
                }
                done();
            }));

            it("are ordered according to status: online, busy, away, xa, unavailable, offline",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await _addContacts(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 700);
                let i, jid;
                for (i=0; i<3; i++) {
                    jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'online');
                }
                for (i=3; i<6; i++) {
                    jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'dnd');
                }
                for (i=6; i<9; i++) {
                    jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'away');
                }
                for (i=9; i<12; i++) {
                    jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'xa');
                }
                for (i=12; i<15; i++) {
                    jid = mock.cur_names[i].replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    _converse.roster.get(jid).presence.set('show', 'unavailable');
                }

                await u.waitUntil(() => u.isVisible(_converse.rosterview.el.querySelector('li:first-child')), 900);
                const roster = _converse.rosterview.el;
                const groups = roster.querySelectorAll('.roster-group');
                const groupnames = Array.from(groups).map(g => g.getAttribute('data-group'));
                expect(groupnames.join(' ')).toBe("Colleagues Family friends & acquaintences ænemies Ungrouped");
                for (let j=0; j<groups.length; j++) {
                    const group = groups[j];
                    const groupname = groupnames[j];
                    const els = Array.from(group.querySelectorAll('.current-xmpp-contact'));
                    expect(els.length).toBe(mock.groups_map[groupname].length);

                    if (groupname === "Colleagues") {
                        const statuses = els.map(e => e.getAttribute('data-status'));
                        const subscription_classes = els.map(e => e.classList[3]);
                        const status_classes = els.map(e => e.classList[4]);
                        expect(statuses.join(" ")).toBe("online online away xa xa xa");
                        expect(status_classes.join(" ")).toBe("online online away xa xa xa");
                        expect(subscription_classes.join(" ")).toBe("both both both both both both");
                    } else if (groupname === "friends & acquaintences") {
                        const statuses = els.map(e => e.getAttribute('data-status'));
                        const subscription_classes = els.map(e => e.classList[3]);
                        const status_classes = els.map(e => e.classList[4]);
                        expect(statuses.join(" ")).toBe("online online dnd dnd away unavailable");
                        expect(status_classes.join(" ")).toBe("online online dnd dnd away unavailable");
                        expect(subscription_classes.join(" ")).toBe("both both both both both both");
                    } else if (groupname === "Family") {
                        const statuses = els.map(e => e.getAttribute('data-status'));
                        const subscription_classes = els.map(e => e.classList[3]);
                        const status_classes = els.map(e => e.classList[4]);
                        expect(statuses.join(" ")).toBe("online dnd");
                        expect(status_classes.join(" ")).toBe("online dnd");
                        expect(subscription_classes.join(" ")).toBe("both both");
                    } else if (groupname === "ænemies") {
                        const statuses = els.map(e => e.getAttribute('data-status'));
                        const subscription_classes = els.map(e => e.classList[3]);
                        const status_classes = els.map(e => e.classList[4]);
                        expect(statuses.join(" ")).toBe("away");
                        expect(status_classes.join(" ")).toBe("away");
                        expect(subscription_classes.join(" ")).toBe("both");
                    } else if (groupname === "Ungrouped") {
                        const statuses = els.map(e => e.getAttribute('data-status'));
                        const subscription_classes = els.map(e => e.classList[3]);
                        const status_classes = els.map(e => e.classList[4]);
                        expect(statuses.join(" ")).toBe("unavailable unavailable");
                        expect(status_classes.join(" ")).toBe("unavailable unavailable");
                        expect(subscription_classes.join(" ")).toBe("both both");
                    }
                }
                done();
            }));
        });

        describe("Requesting Contacts", function () {

            it("can be added to the roster and they will be sorted alphabetically",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                test_utils.openControlBox(_converse);
                let names = [];
                const addName = function (item) {
                    if (!u.hasClass('request-actions', item)) {
                        names.push(item.textContent.replace(/^\s+|\s+$/g, ''));
                    }
                };
                spyOn(_converse.rosterview, 'update').and.callThrough();
                await Promise.all(mock.req_names.map(name => {
                    const contact = _converse.roster.create({
                        jid: name.replace(/ /g,'.').toLowerCase() + '@montague.lit',
                        subscription: 'none',
                        ask: null,
                        requesting: true,
                        nickname: name
                    });
                    return u.waitUntil(() => contact.initialized);
                }));
                await u.waitUntil(() => _converse.rosterview.get('Contact requests').el.querySelectorAll('li').length, 700);
                expect(_converse.rosterview.update).toHaveBeenCalled();
                // Check that they are sorted alphabetically
                const children = _converse.rosterview.get('Contact requests').el.querySelectorAll('.requesting-xmpp-contact span');
                names = [];
                Array.from(children).forEach(addName);
                expect(names.join('')).toEqual(mock.req_names.slice(0,mock.req_names.length+1).sort().join(''));
                done();
            }));

            it("do not have a header if there aren't any",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, "current", 0);
                const name = mock.req_names[0];
                spyOn(window, 'confirm').and.returnValue(true);
                _converse.roster.create({
                    'jid': name.replace(/ /g,'.').toLowerCase() + '@montague.lit',
                    'subscription': 'none',
                    'ask': null,
                    'requesting': true,
                    'nickname': name
                });
                await u.waitUntil(() => sizzle('.roster-group', _converse.rosterview.el).filter(u.isVisible).length, 900);
                expect(u.isVisible(_converse.rosterview.get('Contact requests').el)).toEqual(true);
                expect(sizzle('.roster-group', _converse.rosterview.el).filter(u.isVisible).map(e => e.querySelector('li')).length).toBe(1);
                sizzle('.roster-group', _converse.rosterview.el).filter(u.isVisible).map(e => e.querySelector('li .decline-xmpp-request'))[0].click();
                expect(window.confirm).toHaveBeenCalled();
                expect(u.isVisible(_converse.rosterview.get('Contact requests').el)).toEqual(false);
                done();
            }));

            it("can be collapsed under their own header",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.waitForRoster(_converse, 'current', 0);
                test_utils.createContacts(_converse, 'requesting');
                await test_utils.openControlBox(_converse);
                await u.waitUntil(() => sizzle('.roster-group', _converse.rosterview.el).filter(u.isVisible).length, 700);
                await checkHeaderToggling.apply(
                    _converse,
                    [_converse.rosterview.get('Contact requests').el]
                );
                done();
            }));

            it("can have their requests accepted by the user",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.openControlBox(_converse);
                await test_utils.waitForRoster(_converse, 'current', 0);
                await test_utils.createContacts(_converse, 'requesting');
                const name = mock.req_names.sort()[0];
                const jid =  name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                const contact = _converse.roster.get(jid);
                spyOn(contact, 'authorize').and.callFake(() => contact);
                await u.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group li').length)
                // TODO: Testing can be more thorough here, the user is
                // actually not accepted/authorized because of
                // mock_connection.
                spyOn(_converse.roster, 'sendContactAddIQ').and.callFake(() => Promise.resolve());
                const req_contact = sizzle(`.req-contact-name:contains("${contact.getDisplayName()}")`, _converse.rosterview.el).pop();
                req_contact.parentElement.parentElement.querySelector('.accept-xmpp-request').click();
                expect(_converse.roster.sendContactAddIQ).toHaveBeenCalled();
                await u.waitUntil(() => contact.authorize.calls.count());
                expect(contact.authorize).toHaveBeenCalled();
                done();
            }));

            it("can have their requests denied by the user",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.waitForRoster(_converse, 'current', 0);
                await test_utils.createContacts(_converse, 'requesting');
                await test_utils.openControlBox(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 700);
                _converse.rosterview.update(); // XXX: Hack to make sure $roster element is attaced.
                const name = mock.req_names.sort()[1];
                const jid =  name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                const contact = _converse.roster.get(jid);
                spyOn(window, 'confirm').and.returnValue(true);
                spyOn(contact, 'unauthorize').and.callFake(function () { return contact; });
                const req_contact = await u.waitUntil(() => sizzle(".req-contact-name:contains('"+name+"')", _converse.rosterview.el).pop());
                req_contact.parentElement.parentElement.querySelector('.decline-xmpp-request').click();
                expect(window.confirm).toHaveBeenCalled();
                expect(contact.unauthorize).toHaveBeenCalled();
                // There should now be one less contact
                expect(_converse.roster.length).toEqual(mock.req_names.length-1);
                done();
            }));

            it("are persisted even if other contacts' change their presence ", mock.initConverse(
                ['rosterGroupsFetched'], {}, async function (done, _converse) {

                /* This is a regression test.
                 * https://github.com/jcbrand/_converse.js/issues/262
                 */
                expect(_converse.roster.pluck('jid').length).toBe(0);

                const sent_IQs = _converse.connection.IQ_stanzas;
                const stanza = await u.waitUntil(() => _.filter(sent_IQs, iq => iq.querySelector('iq query[xmlns="jabber:iq:roster"]')).pop());
                // Taken from the spec
                // https://xmpp.org/rfcs/rfc3921.html#rfc.section.7.3
                const result = $iq({
                    to: _converse.connection.jid,
                    type: 'result',
                    id: stanza.getAttribute('id')
                }).c('query', {
                    xmlns: 'jabber:iq:roster',
                }).c('item', {
                    jid: 'juliet@example.net',
                    name: 'Juliet',
                    subscription:'both'
                }).c('group').t('Friends').up().up()
                .c('item', {
                    jid: 'mercutio@example.org',
                    name: 'Mercutio',
                    subscription:'from'
                }).c('group').t('Friends').up().up()
                _converse.connection._dataRecv(test_utils.createRequest(result));

                const pres = $pres({from: 'data@enterprise/resource', type: 'subscribe'});
                _converse.connection._dataRecv(test_utils.createRequest(pres));
                expect(_converse.roster.pluck('jid').length).toBe(1);
                await u.waitUntil(() => sizzle('a:contains("Contact requests")', _converse.rosterview.el).length, 700);
                expect(_converse.roster.pluck('jid').includes('data@enterprise')).toBeTruthy();

                const roster_push = $iq({
                    'to': _converse.connection.jid,
                    'type': 'set',
                }).c('query', {'xmlns': 'jabber:iq:roster', 'ver': 'ver34'})
                    .c('item', {
                        jid: 'benvolio@example.org',
                        name: 'Benvolio',
                        subscription:'both'
                    }).c('group').t('Friends');
                _converse.connection._dataRecv(test_utils.createRequest(roster_push));
                expect(_converse.roster.data.get('version')).toBe('ver34');
                expect(_converse.roster.models.length).toBe(4);
                expect(_converse.roster.pluck('jid').includes('data@enterprise')).toBeTruthy();
                done();
            }));
        });

        describe("All Contacts", function () {

            it("are saved to, and can be retrieved from browserStorage",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.waitForRoster(_converse, 'current', 0);
                await test_utils.createContacts(_converse, 'requesting');
                await test_utils.openControlBox(_converse);
                var new_attrs, old_attrs, attrs;
                var num_contacts = _converse.roster.length;
                var new_roster = new _converse.RosterContacts();
                // Roster items are yet to be fetched from browserStorage
                expect(new_roster.length).toEqual(0);
                new_roster.browserStorage = _converse.roster.browserStorage;
                await new Promise(success => new_roster.fetch({success}));
                expect(new_roster.length).toEqual(num_contacts);
                // Check that the roster items retrieved from browserStorage
                // have the same attributes values as the original ones.
                attrs = ['jid', 'fullname', 'subscription', 'ask'];
                for (var i=0; i<attrs.length; i++) {
                    new_attrs = _.map(_.map(new_roster.models, 'attributes'), attrs[i]);
                    old_attrs = _.map(_.map(_converse.roster.models, 'attributes'), attrs[i]);
                    // Roster items in storage are not necessarily sorted,
                    // so we have to sort them here to do a proper
                    // comparison
                    expect(_.isEqual(new_attrs.sort(), old_attrs.sort())).toEqual(true);
                }
                done();
            }));

            it("will show fullname and jid properties on tooltip",
                mock.initConverse(
                    ['rosterGroupsFetched'], {},
                    async function (done, _converse) {

                await test_utils.waitForRoster(_converse, 'current', 'all');
                await test_utils.createContacts(_converse, 'requesting');
                await test_utils.openControlBox(_converse);
                await u.waitUntil(() => sizzle('.roster-group li', _converse.rosterview.el).length, 700);
                await Promise.all(mock.cur_names.map(async name => {
                    const jid = name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    const el = await u.waitUntil(() => sizzle("li:contains('"+name+"')", _converse.rosterview.el).pop());
                    const child = el.firstElementChild;
                    expect(child.textContent.trim()).toBe(name);
                    expect(child.getAttribute('title')).toContain(name);
                    expect(child.getAttribute('title')).toContain(jid);
                }));
                await Promise.all(mock.req_names.map(async name => {
                    const jid = name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
                    const el = await u.waitUntil(() => sizzle("li:contains('"+name+"')", _converse.rosterview.el).pop());
                    const child = el.firstElementChild;
                    expect(child.textContent.trim()).toBe(name);
                    expect(child.firstElementChild.getAttribute('title')).toContain(jid);
                }));
                done();
            }));
        });
    });
}));