瀏覽代碼

refactor: improve Object3D disposal method (#918)

- Remove unnecessary delete operations on mesh geometry and material
- Add TODO comment for Scene-specific cleanup
- Simplify material and geometry disposal logic
Alvaro Saburido 3 月之前
父節點
當前提交
1d40ccff9e
共有 1 個文件被更改,包括 1 次插入4 次删除
  1. 1 4
      src/utils/index.ts

+ 1 - 4
src/utils/index.ts

@@ -294,7 +294,7 @@ export function disposeObject3D(object: TresObject): void {
   children.forEach(child => disposeObject3D(child))
 
   if (object instanceof Scene) {
-    // Optionally handle Scene-specific cleanup
+    // TODO: Handle Scene-specific cleanup
   }
   else {
     const mesh = object as unknown as Partial<Mesh>
@@ -303,16 +303,13 @@ export function disposeObject3D(object: TresObject): void {
     }
     if (mesh.geometry) {
       mesh.geometry.dispose()
-      delete mesh.geometry
     }
 
     if (Array.isArray(mesh.material)) {
       mesh.material.forEach(material => disposeMaterial(material))
-      delete mesh.material
     }
     else if (mesh.material) {
       disposeMaterial(mesh.material)
-      delete mesh.material
     }
   }
 }