Browse Source

Merge pull request #176 from Tresjs/feature/add-0px-height-canvas-parent-warning

feat: adding warning when  canvas parent height is 0px
Alvaro Saburido 2 năm trước cách đây
mục cha
commit
5460d55bd8

+ 6 - 1
src/composables/useRenderer/index.ts

@@ -152,11 +152,16 @@ export function useRenderer(canvas: MaybeElementRef, container: MaybeElementRef,
   const { setState } = useTres()
   const { setState } = useTres()
 
 
   const { width, height } = resolveUnref(windowSize) ? useWindowSize() : useElementSize(container)
   const { width, height } = resolveUnref(windowSize) ? useWindowSize() : useElementSize(container)
-  const { logError } = useLogger()
+  const { logError, logWarning } = useLogger()
   const { pixelRatio } = useDevicePixelRatio()
   const { pixelRatio } = useDevicePixelRatio()
   const { pause, resume } = useRenderLoop()
   const { pause, resume } = useRenderLoop()
   const aspectRatio = computed(() => width.value / height.value)
   const aspectRatio = computed(() => width.value / height.value)
 
 
+  if (!resolveUnref(windowSize) && container?.value?.offsetHeight === 0) {
+    logWarning(`Oops... Seems like your canvas height is currently 0px, by default it takes the height of it's parent, so make sure it has some height with CSS.
+You could set windowSize=true to force the canvas to be the size of the window.`)
+  }
+
   const updateRendererSize = () => {
   const updateRendererSize = () => {
     if (!renderer.value) {
     if (!renderer.value) {
       return
       return