1
0
Эх сурвалжийг харах

feat: add deprecation warnings to disableRender

alvarosabu 1 жил өмнө
parent
commit
5ed57c4776

+ 6 - 3
src/components/TresCanvas.vue

@@ -55,6 +55,9 @@ export interface TresCanvasProps
   camera?: TresCamera
   preset?: RendererPresetsType
   windowSize?: boolean
+  /**
+   * @deprecated since version 4.2. Use `take-over render loop` approach instead. To be fully removed on v5. See https://docs.tresjs.org/api/composables.html#take-over-the-render-loop
+   */
   disableRender?: boolean
 }
 
@@ -65,6 +68,9 @@ const props = withDefaults(defineProps<TresCanvasProps>(), {
   stencil: undefined,
   antialias: undefined,
   windowSize: undefined,
+  /**
+   * @deprecated since version 4.2. Use `take-over render loop` approach instead. To be fully removed on v5. See https://docs.tresjs.org/api/composables.html#take-over-the-render-loop
+   */
   disableRender: undefined,
   useLegacyLights: undefined,
   preserveDrawingBuffer: undefined,
@@ -144,8 +150,6 @@ const dispose = (context: TresContext, force = false) => {
   mountCustomRenderer(context)
 }
 
-const disableRender = computed(() => props.disableRender)
-
 const context = shallowRef<TresContext | null>(null)
 
 defineExpose({ context, dispose: () => dispose(context.value as TresContext, true) })
@@ -157,7 +161,6 @@ onMounted(() => {
     scene: scene.value as TresScene,
     canvas: existingCanvas,
     windowSize: props.windowSize ?? false,
-    disableRender: disableRender.value ?? false,
     rendererOptions: props,
     emit,
   })

+ 0 - 1
src/composables/useRenderer/index.ts

@@ -111,7 +111,6 @@ export function useRenderer(
     options: UseRendererOptions
     emit: EmitEventFn
     contextParts: Pick<TresContext, 'sizes' | 'camera' | 'render'> & { invalidate: () => void, advance: () => void }
-    disableRender: MaybeRefOrGetter<boolean>
   },
 ) {
   const webGLRendererConstructorParameters = computed<WebGLRendererParameters>(() => ({

+ 0 - 3
src/composables/useTresContextProvider/index.ts

@@ -88,14 +88,12 @@ export function useTresContextProvider({
   scene,
   canvas,
   windowSize,
-  disableRender,
   rendererOptions,
   emit,
 }: {
   scene: TresScene
   canvas: MaybeRef<HTMLCanvasElement>
   windowSize: MaybeRefOrGetter<boolean>
-  disableRender: MaybeRefOrGetter<boolean>
   rendererOptions: UseRendererOptions
   emit: EmitEventFn
 
@@ -150,7 +148,6 @@ export function useTresContextProvider({
       emit,
       // TODO: replace contextParts with full ctx at https://github.com/Tresjs/tres/issues/516
       contextParts: { sizes, camera, render, invalidate, advance },
-      disableRender,
     },
   )