Browse Source

fix(utils): reorder object disposal to avoid issue with Helper `dispose` methods (#683)

Alvaro Saburido 1 year ago
parent
commit
e5a2cef0e4
1 changed files with 3 additions and 3 deletions
  1. 3 3
      src/utils/index.ts

+ 3 - 3
src/utils/index.ts

@@ -295,6 +295,9 @@ export function disposeObject3D(object: TresObject): void {
   }
   else {
     const mesh = object as unknown as Partial<Mesh>
+    if (object) {
+      object.dispose?.()
+    }
     if (mesh.geometry) {
       mesh.geometry.dispose()
       delete mesh.geometry
@@ -308,8 +311,5 @@ export function disposeObject3D(object: TresObject): void {
       disposeMaterial(mesh.material)
       delete mesh.material
     }
-    if (object) {
-      object.dispose?.()
-    }
   }
 }