Home Explore Help
Register Sign In
oleg
/
alpine
mirror of https://github.com/alpinejs/alpine.git
1
0
Fork 0
Files Issues 0 Wiki
Browse Source

Merge branch 'master' into bug/nested-proxies

Caleb Porzio 5 years ago
parent
213b33a11d 6cb92fd8f4
commit
107e452c9b
4 changed files with 28 additions and 3 deletions
Unified View Show Diff Stats
  1. 1 1
      README.md
  2. 1 1
      package.json
  3. 1 1
      src/index.js
  4. 25 0
      test/mutations.spec.js

+ 1 - 1
README.md
View File 

@@ -14,7 +14,7 @@ Think of it like [Tailwind](https://tailwindcss.com/) for JavaScript.
 
 
 
 **From CDN:** Add the following script to the end of your `<head>` section.
 
 **From CDN:** Add the following script to the end of your `<head>` section.
 
 ```html
 
 ```html
 
-<script src="https://cdn.jsdelivr.net/gh/alpinejs/alpine@v1.9.5/dist/alpine.js" defer></script>
 
+<script src="https://cdn.jsdelivr.net/gh/alpinejs/alpine@v1.9.6/dist/alpine.js" defer></script>
 
 ```
 
 ```
 
 
 
 That's it. It will initialize itself.
 
 That's it. It will initialize itself.

+ 1 - 1
package.json
View File 

@@ -1,7 +1,7 @@
 
 {
 
 {
 
   "main": "dist/alpine.js",
 
   "main": "dist/alpine.js",
 
   "name": "alpinejs",
 
   "name": "alpinejs",
 
-  "version": "1.9.5",
 
+  "version": "1.9.6",
 
   "repository": {
 
   "repository": {
 
     "type": "git",
 
     "type": "git",
 
     "url": "git://github.com/alpinejs/alpine.git"
 
     "url": "git://github.com/alpinejs/alpine.git"

+ 1 - 1
src/index.js
View File 

@@ -60,7 +60,7 @@ const Alpine = {
 
 
 
                         // Discard any changes happening within an existing component.
 
                         // Discard any changes happening within an existing component.
 
                         // They will take care of themselves.
 
                         // They will take care of themselves.
 
-                        if (node.parentElement.closest('[x-data]')) return
 
+                        if (node.parentElement && node.parentElement.closest('[x-data]')) return
 
 
 
                         this.discoverUninitializedComponents((el) => {
 
                         this.discoverUninitializedComponents((el) => {
 
                             this.initializeComponent(el)
 
                             this.initializeComponent(el)

+ 25 - 0
test/mutations.spec.js
View File 

@@ -0,0 +1,25 @@
 
+import Alpine from 'alpinejs'
 
+
 
+test('catch disconnected nodes that were used as targets for any mutations', async () => {
 
+    const runObservers = []
 
+
 
+    global.MutationObserver = class {
 
+        constructor(callback) { runObservers.push(callback) }
 
+        observe() {}
 
+    }
 
+
 
+    document.body.innerHTML = `
 
+        <div x-data="{}">
 
+        </div>
 
+    `
 
+
 
+    Alpine.start()
 
+
 
+    runObservers.forEach(cb => cb([
 
+        {
 
+            target: document.createElement('div'),
 
+            type: 'childList',
 
+            addedNodes: [ document.createElement('div') ],
 
+        }
 
+    ]))
 
+})