소스 검색

be more careful with the index to groupMemberIds

memberManagementRows may grow now,
however, usually together with groupMemberIds,
so, this is only a general precaution.

the change results in passing 0 as contact_id around in case of errors,
however, this is fine, core will take care of it
(will result in 'careless calls' warnings).
B. Petersen 3 년 전
부모
커밋
68f679b2c5
1개의 변경된 파일6개의 추가작업 그리고 1개의 파일을 삭제
  1. 6 1
      deltachat-ios/Controller/GroupChatDetailViewController.swift

+ 6 - 1
deltachat-ios/Controller/GroupChatDetailViewController.swift

@@ -354,7 +354,12 @@ class GroupChatDetailViewController: UIViewController {
      }
 
     private func getGroupMemberIdFor(_ row: Int) -> Int {
-        return groupMemberIds[row - memberManagementRows]
+        let index = row - memberManagementRows
+        if index >= 0 && index < groupMemberIds.count {
+            return groupMemberIds[index]
+        } else {
+            return 0
+        }
     }
 
     private func isMemberManagementRow(row: Int) -> Bool {