implement ephemeral messages settings for groups

deltachat-ios/Controller/ContactDetailViewController.swift

@@ -27,10 +27,8 @@ class ContactDetailViewController: UITableViewController {
     }()
 
     private lazy var ephemeralMessagesCell: UITableViewCell = {
-        let cell = UITableViewCell(style: .value1, reuseIdentifier: nil)
+        let cell = UITableViewCell(style: .default, reuseIdentifier: nil)
         cell.textLabel?.text = String.localized("pref_ephemeral_messages")
-        let value = SettingsEphemeralMessageController.getValString(val: viewModel.context.getChatEphemeralTimer(chatId: viewModel.chatId))
-        cell.detailTextLabel?.text = value
         cell.selectionStyle = .none
         cell.accessoryType = .disclosureIndicator
         return cell

deltachat-ios/Controller/GroupChatDetailViewController.swift

@@ -14,10 +14,11 @@ class GroupChatDetailViewController: UIViewController {
     private let membersRowAddMembers = 0
     private let membersRowQrInvite = 1
     private let memberManagementRows = 2
-    private let chatActionsRowMuteChat = 0
-    private let chatActionsRowArchiveChat = 1
-    private let chatActionsRowLeaveGroup = 2
-    private let chatActionsRowDeleteChat = 3
+    private let chatActionsRowEphemeralMessages = 0
+    private let chatActionsRowMuteChat = 1
+    private let chatActionsRowArchiveChat = 2
+    private let chatActionsRowLeaveGroup = 3
+    private let chatActionsRowDeleteChat = 4
 
     private let dcContext: DcContext
 
@@ -71,6 +72,14 @@ class GroupChatDetailViewController: UIViewController {
         return header
     }()
 
+    private lazy var ephemeralMessagesCell: UITableViewCell = {
+        let cell = UITableViewCell(style: .default, reuseIdentifier: nil)
+        cell.textLabel?.text = String.localized("pref_ephemeral_messages")
+        cell.selectionStyle = .none
+        cell.accessoryType = .disclosureIndicator
+        return cell
+    }()
+
     private lazy var muteChatCell: ActionCell = {
         let cell = ActionCell()
         cell.actionTitle = self.chat.isMuted ? String.localized("menu_unmute") :  String.localized("menu_mute")
@@ -331,7 +340,9 @@ extension GroupChatDetailViewController: UITableViewDelegate, UITableViewDataSou
             contactCell.updateCell(cellViewModel: cellViewModel)
             return contactCell
         case .chatActions:
-            if row == chatActionsRowMuteChat {
+            if row == chatActionsRowEphemeralMessages {
+                return ephemeralMessagesCell
+            } else if row == chatActionsRowMuteChat {
                 return muteChatCell
             } else if row == chatActionsRowArchiveChat {
                 return archiveChatCell
@@ -366,7 +377,9 @@ extension GroupChatDetailViewController: UITableViewDelegate, UITableViewDataSou
                 showContactDetail(of: member.id)
             }
         case .chatActions:
-            if row == chatActionsRowMuteChat {
+            if row == chatActionsRowEphemeralMessages {
+                showEphemeralMessagesController()
+            } else if row == chatActionsRowMuteChat {
                 if chat.isMuted {
                     dcContext.setChatMuteDuration(chatId: chatId, duration: 0)
                     muteChatCell.actionTitle = String.localized("menu_mute")
@@ -447,6 +460,11 @@ extension GroupChatDetailViewController: UITableViewDelegate, UITableViewDataSou
         self.tableView.deleteRows(at: [indexPath], with: .automatic)
         updateHeader()  // to display correct group size
     }
+
+    private func showEphemeralMessagesController() {
+        let ephemeralMessagesController = SettingsEphemeralMessageController(dcContext: dcContext, chatId: chatId)
+        navigationController?.pushViewController(ephemeralMessagesController, animated: true)
+    }
 }
 
 // MARK: - alerts

deltachat-ios/Controller/SettingsEphemeralMessageController.swift

@@ -30,7 +30,7 @@ class SettingsEphemeralMessageController: UITableViewController {
         self.dcContext = dcContext
         self.chatId = chatId
         super.init(style: .grouped)
-        self.title = String.localized("pref_show_emails")
+        self.title = String.localized("pref_ephemeral_messages")
         hidesBottomBarWhenPushed = true
     }