Browse Source

Remove unused IDisposable array

The IDisposables created by the registration of language providers
were originally stored in an array. However, that array is not
actually used anywhere in the code so it should be removed instead.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
Remy Suen 7 years ago
parent
commit
8045997506
1 changed files with 6 additions and 10 deletions
  1. 6 10
      src/htmlMode.ts

+ 6 - 10
src/htmlMode.ts

@@ -11,14 +11,10 @@ import * as languageFeatures from './languageFeatures';
 
 
 import Promise = monaco.Promise;
 import Promise = monaco.Promise;
 import Uri = monaco.Uri;
 import Uri = monaco.Uri;
-import IDisposable = monaco.IDisposable;
 
 
 export function setupMode(defaults: LanguageServiceDefaultsImpl): void {
 export function setupMode(defaults: LanguageServiceDefaultsImpl): void {
 
 
-	let disposables: IDisposable[] = [];
-
 	const client = new WorkerManager(defaults);
 	const client = new WorkerManager(defaults);
-	disposables.push(client);
 
 
 	const worker: languageFeatures.WorkerAccessor = (...uris: Uri[]): Promise<HTMLWorker> => {
 	const worker: languageFeatures.WorkerAccessor = (...uris: Uri[]): Promise<HTMLWorker> => {
 		return client.getLanguageServiceWorker(...uris);
 		return client.getLanguageServiceWorker(...uris);
@@ -27,14 +23,14 @@ export function setupMode(defaults: LanguageServiceDefaultsImpl): void {
 	let languageId = defaults.languageId;
 	let languageId = defaults.languageId;
 
 
 	// all modes
 	// all modes
-	disposables.push(monaco.languages.registerCompletionItemProvider(languageId, new languageFeatures.CompletionAdapter(worker)));
-	disposables.push(monaco.languages.registerDocumentHighlightProvider(languageId, new languageFeatures.DocumentHighlightAdapter(worker)));
-	disposables.push(monaco.languages.registerLinkProvider(languageId, new languageFeatures.DocumentLinkAdapter(worker)));
+	monaco.languages.registerCompletionItemProvider(languageId, new languageFeatures.CompletionAdapter(worker));
+	monaco.languages.registerDocumentHighlightProvider(languageId, new languageFeatures.DocumentHighlightAdapter(worker));
+	monaco.languages.registerLinkProvider(languageId, new languageFeatures.DocumentLinkAdapter(worker));
 
 
 	// only html
 	// only html
 	if (languageId === 'html') {
 	if (languageId === 'html') {
-		disposables.push(monaco.languages.registerDocumentFormattingEditProvider(languageId, new languageFeatures.DocumentFormattingEditProvider(worker)));
-		disposables.push(monaco.languages.registerDocumentRangeFormattingEditProvider(languageId, new languageFeatures.DocumentRangeFormattingEditProvider(worker)));
-		disposables.push(new languageFeatures.DiagnostcsAdapter(languageId, worker));
+		monaco.languages.registerDocumentFormattingEditProvider(languageId, new languageFeatures.DocumentFormattingEditProvider(worker));
+		monaco.languages.registerDocumentRangeFormattingEditProvider(languageId, new languageFeatures.DocumentRangeFormattingEditProvider(worker));
+		new languageFeatures.DiagnostcsAdapter(languageId, worker);
 	}
 	}
 }
 }