Prechádzať zdrojové kódy

deactivate negotationneeded to avoid breaking in Chrome 66

this broke with Chrome 66 because of
    https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/discuss-webrtc/Qxj38DwiJPU/5eCOPWvwBgAJ
and negotiationneeded being generally weird in Chrome.
Philipp Hancke 7 rokov pred
rodič
commit
bd7123ee83
1 zmenil súbory, kde vykonal 3 pridanie a 1 odobranie
  1. 3 1
      lib/util.js

+ 3 - 1
lib/util.js

@@ -93,7 +93,7 @@ var util = {
 
 
     var binaryBlob = false;
     var binaryBlob = false;
     var sctp = false;
     var sctp = false;
-    var onnegotiationneeded = !!window.webkitRTCPeerConnection;
+    var onnegotiationneeded = false;
 
 
     var pc, dc;
     var pc, dc;
     try {
     try {
@@ -138,6 +138,7 @@ var util = {
 
 
     // FIXME: this is not great because in theory it doesn't work for
     // FIXME: this is not great because in theory it doesn't work for
     // av-only browsers (?).
     // av-only browsers (?).
+    /*
     if (!onnegotiationneeded && data) {
     if (!onnegotiationneeded && data) {
       // sync default check.
       // sync default check.
       var negotiationPC = new RTCPeerConnection(defaultConfig, {optional: [{RtpDataChannels: true}]});
       var negotiationPC = new RTCPeerConnection(defaultConfig, {optional: [{RtpDataChannels: true}]});
@@ -154,6 +155,7 @@ var util = {
         negotiationPC.close();
         negotiationPC.close();
       }, 1000);
       }, 1000);
     }
     }
+    */
 
 
     if (pc) {
     if (pc) {
       pc.close();
       pc.close();