瀏覽代碼

Update MediaDeletePipeline, fix async media deletion

Daniel Supernault 3 年之前
父節點
當前提交
bb1cccbe03

+ 2 - 2
app/Console/Commands/MediaGarbageCollector.php

@@ -51,10 +51,10 @@ class MediaGarbageCollector extends Command
 		$bar = $this->output->createProgressBar($gc->count());
 		$bar = $this->output->createProgressBar($gc->count());
 		$bar->start();
 		$bar->start();
 		foreach($gc as $media) {
 		foreach($gc as $media) {
-			MediaStorageService::delete($media);
-			$media->forceDelete();
+			MediaStorageService::delete($media, true);
 			$bar->advance();
 			$bar->advance();
 		}
 		}
 		$bar->finish();
 		$bar->finish();
+		$this->line('');
 	}
 	}
 }
 }

+ 0 - 2
app/Http/Controllers/ComposeController.php

@@ -228,8 +228,6 @@ class ComposeController extends Controller
 
 
 		MediaStorageService::delete($media, true);
 		MediaStorageService::delete($media, true);
 
 
-		$media->forceDelete();
-
 		return response()->json([
 		return response()->json([
 			'msg' => 'Successfully deleted',
 			'msg' => 'Successfully deleted',
 			'code' => 200
 			'code' => 200

+ 3 - 1
app/Jobs/MediaPipeline/MediaDeletePipeline.php

@@ -57,7 +57,9 @@ class MediaDeletePipeline implements ShouldQueue
 			$disk->deleteDirectory($i);
 			$disk->deleteDirectory($i);
 		}
 		}
 
 
-		return 1;
+		$media->forceDelete();
+
+		return;
 	}
 	}
 
 
 }
 }