Sfoglia il codice sorgente

remove nuking of hash changes when hash is disabled

Hakim El Hattab 5 anni fa
parent
commit
ba0b367ed9
3 ha cambiato i file con 7 aggiunte e 3 eliminazioni
  1. 0 0
      dist/reveal.esm.js
  2. 0 0
      dist/reveal.js
  3. 7 3
      js/controllers/location.js

File diff suppressed because it is too large
+ 0 - 0
dist/reveal.esm.js


File diff suppressed because it is too large
+ 0 - 0
dist/reveal.js


+ 7 - 3
js/controllers/location.js

@@ -131,12 +131,16 @@ export default class Location {
 			else if( config.hash ) {
 				window.history.replaceState( null, null, '#' + this.getHash() );
 			}
+			// UPDATE: The below nuking of all hash changes breaks
+			// anchors on pages where reveal.js is running. Removed
+			// in 4.0. Why was it here in the first place? ¯\_(ツ)_/¯
+			//
 			// If history and hash are both disabled, a hash may still
 			// be added to the URL by clicking on a href with a hash
 			// target. Counter this by always removing the hash.
-			else {
-				window.history.replaceState( null, null, window.location.pathname + window.location.search );
-			}
+			// else {
+			// 	window.history.replaceState( null, null, window.location.pathname + window.location.search );
+			// }
 		}
 
 	}

Some files were not shown because too many files changed in this diff