fix(array methods)

src/observable.js

@@ -1,9 +1,9 @@
-import { isNullOrUndefined, isObject } from './utils'
+import { isNullOrUndefined, isObject, isArray } from './utils'
 
 export const createObservable = (target, callbacks) => {
-    Object.keys(target).forEach(key => {
-        if (! isNullOrUndefined(target[key]) && isObject(target[key])) {
-            target[key] = createObservable(target[key], callbacks)
+    Object.entries(target).forEach(([key, value]) => {
+        if (! isNullOrUndefined(value) && (isObject(value) || isArray(value))) {
+            target[key] = createObservable(value, callbacks)
         }
     })
 

src/utils.js

@@ -24,4 +24,6 @@ export const isNullOrUndefined = value => {
 
 export const isObject = _ => {
     return Object.getPrototypeOf(_) === Object.prototype
-}
+}
+
+export const isArray = _ => Array.isArray(_)

tests/observable.spec.js

@@ -40,4 +40,27 @@ test('createObservable > will run callback on set trap', () => {
     observable.foo = 'bob'
 
     expect(fixture).toEqual(100)
+})
+
+test('createObservable > will run set trap for Array.* methods', () => {
+    let target = {
+        items: [
+            'foo',
+            'bar'
+        ],
+    }
+
+
+    let fixture
+
+    let observable = createObservable(target, {
+        set() {
+            fixture = 'baz'
+        }
+    })
+
+    observable.items.push('baz')
+
+    expect(target.items).toContain('baz')
+    expect(fixture).toEqual('baz')
 })